From: Mark S. <mar...@gm...> - 2008-11-30 16:11:01
|
You mis-understood... or I mis-understood. I was not really seeking "compliments". With your initial response about limiting hexes to those that are legal with track awareness that was not yet ready, I thought you had not understood why I fixed the code. Part of the reason to code this stuff, as I am sure you agree, is to prevent "honest" mistakes... or even "dis-honest" play by a person. The fix I applied at least prevents the illegal token lay from being performed, even if from a UI standpoint it does the test later than it should. And that reminds me of the other point I failed to mention. WIth 1851, the L&N Home, when I attempted to place the token on the tile, (whether for L&N or another Company), because there were two seperate cities, it asked which did I want to place it on, even though only one (the south western one) had an empty slot. If there is only one empty slot on the tile, the dialog is not necessary. I have updated the ORUIManager.java routine in two places where the SelectStationForToken Text is retrieved to check that more than one item will be displayed. If only one, the dialog is not required, and it will auto-select the first one. Mark On Sun, Nov 30, 2008 at 9:52 AM, Erik Vos <eri...@hc...> wrote: > With the way the routine I updated was written it was ALWAYS going to > return FALSE. The contains would never find the 'PublicCompanyI' in the > ArrayList<TokenI>. > > Yes, I should have been more careful when writing that code. > Good fix (I had accepted it without any comments - perhaps you had expected > some). > > Erik > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > Build the coolest Linux based applications with Moblin SDK & win great > prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > > |