Re: [Rails-devel] Bugs fixed

[Mark S. <mar...@gm...>]

On Sun, Oct 19, 2008 at 2:27 PM, Erik Vos <eri...@hc...> wrote:

> I have fixed a number of bugs, some of which have been reported my Mark.
>
> 1. Wrong home city for L&N in 1851.
>

I was attempting to checkin the XML File to fix this issue, and ran across
my XCode to CVS Checkin Issues. I have yet to resolve this, but this is
fine.


>
> 2. No 2 yellow tiles allowed in 1851 from phase 3. Also relevant to 1835
> (major companies, phase 2) and 1870 (all phases). It was caused by the
> introduction of a more complex XML structure for this feature with 18EU,
> which was not retrofitted to these other games.


Oh, so this was not an outright code failure, but something else...
interesting.


>
>
> 3. My recent fix for the method calling loop was bad (it caused all
> privates
> having all special properties that exist in one game).


Whatever...

>
>
> 4. 1835 had a bug that did not allow this game even to start.
>
>
> On another problem reported by Mark:
>
>        When attempting to step through the game, I started L&N and GM&O in
> OR 1, in SR 2 I sold GM&O so that it's stock value was
>        below L&N, then in OR 2, L&N Ran first, after completing that run,
> GM&O was not given a chance to operate at all.
>
> I could not reproduce this behaviour. Mark, what exact sequence of actions
> led to this situation? (And are you sure you haven't misunderstood the
> appearance of the Status Window during the share trading step at the end of
> each company's OR turn, from OR2 on?)


I admit I have not read the rules for 1851 in detail. If there is a special
situation that while in the middle of an Operating Round, a Share Round is
initiated for some special reason, then I withdraw my "bug". I am used to
the "old-school" 18XX games (1829, 1830, 1835, 1853, 1856, 1870, 1837) where
you stay in Operating Rounds until every company has operated.


>
>
>
> I'm also looking at implementing Mark's suggestion to mention the current
> phase in the UI. I think I'm going to add a new ModelObject subclass (e.g.
> GameStatusModel) into GameManager, to which the various windows can
> subscribe for getting info like current phase, current player, current
> round. That will bring the flow of such status information from engine to
> UI
> on the same basis as much of the other displayed items. Hopefully this will
> ease the future client/server split another bit.
>

To go along with this thought, not only show the Phase, but may next to the
new label "Phase X", have 1-4 hexes set with the color of available tiles
(Yellow, Green, Brown/Russet, Gray) that are available in the Phase. Don't
show any track just a solid hex filled with the color. Maybe for those that
don't like to rely just on color include word or initials (Y, Gn, B, Gy)
centered in the hex as well.


>
> Erik Vos
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's
> challenge
> Build the coolest Linux based applications with Moblin SDK & win great
> prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>