[Rails-devel] Bugs fixed

[Erik V. <eri...@hc...>]

I have fixed a number of bugs, some of which have been reported my Mark.

1. Wrong home city for L&N in 1851.

2. No 2 yellow tiles allowed in 1851 from phase 3. Also relevant to 1835
(major companies, phase 2) and 1870 (all phases). It was caused by the
introduction of a more complex XML structure for this feature with 18EU,
which was not retrofitted to these other games.

3. My recent fix for the method calling loop was bad (it caused all privates
having all special properties that exist in one game).

4. 1835 had a bug that did not allow this game even to start.


On another problem reported by Mark:

	When attempting to step through the game, I started L&N and GM&O in
OR 1, in SR 2 I sold GM&O so that it's stock value was
	below L&N, then in OR 2, L&N Ran first, after completing that run,
GM&O was not given a chance to operate at all.

I could not reproduce this behaviour. Mark, what exact sequence of actions
led to this situation? (And are you sure you haven't misunderstood the
appearance of the Status Window during the share trading step at the end of
each company's OR turn, from OR2 on?)


I'm also looking at implementing Mark's suggestion to mention the current
phase in the UI. I think I'm going to add a new ModelObject subclass (e.g.
GameStatusModel) into GameManager, to which the various windows can
subscribe for getting info like current phase, current player, current
round. That will bring the flow of such status information from engine to UI
on the same basis as much of the other displayed items. Hopefully this will
ease the future client/server split another bit.

Erik Vos