[Rails-devel] Bugs fixed

[Erik V. <eri...@hc...>]

Having been made aware of some new (well, 5 months old) entries in the bugs
list, I have gone through that list and made some fixes. Some bug reports I
cannot reproduce and need further explanation or will be rejected. One or
two are actually feature requests.

1945743 Blocked hex sides are not shown on the map.
True, but this is a feature request, which I have created: 2161464, closing
this bug report.
It should be possible to draw thick lines over those hex sides, and IMO this
should be done in a way that those lines also show on top of laid tiles
(unlike in the real game).

1945754 Can't see where it shows who has the priority deal.
Wasn't sure if this is actually a question or a feature request, decided to
interpret it as both.
- Answer to the question: On the Game status map ("PD" after the priority
player name).
- Request: it has been asked before to also show the PD player in the map
window (FR 1518278). Then I rejected it, but as it was actually easy to
implement, I have added it now (also to prevent future requests!).

1994548 1851 allows negative company treasury amounts.
I cannot reproduce this problem. Please show how this can be reproduced (if
still the case).

1945691 Can't buy trains across from other companies.
I cannot reproduce this problem. Please show how this can be reproduced (if
still the case).

1945678 1851 Company paying double for shares bought from the pool.
I cannot reproduce this problem. Please show how this can be reproduced (if
still the case).

1945675 1851 No multiple yellow track lays from phase 3.
Confirmed. It has worked in the past, so some recent change must have broken
it.
As Mark Smith has volunteered to sort out this and other tile laying issues,
I'll leave this one to him.

Fixed one more functional bug:

When a company has a train but no revenue (because no route), the allocation
question (pay/split/withold) is still asked. This question is now suppressed
if the revenue is $0.

A few problems causing the game to abort have also been fixed.
All fixes have been committed.

Erik Vos