Re: [Rails-devel] Haven't got the mail list stuff straight

[Mark S. <mar...@gm...>]

I did start the chain to the Rails-devel list...apparently in the process of
replying it did not get all, so the rails devel list address got lost along
the way. I added it back to the "TO" line here.

I can indeed synchronize with the repository and find new changes.

I still need to write up my notes on getting XCode to run well with it.

On Sun, Oct 12, 2008 at 4:37 AM, Erik Vos <eri...@hc...> wrote:

>  BTW, if you want to "earn" commit rights by providing good code
> improvements, you might better provide these to the rails-devel maillist or
> directly to Brett Lentz, as he is managing access. I'm just the guy who
> turns out to have written most of the code....
> If you want, I'm willing to witness 2 points for good patches....
>
> I'll include the missing which_price change later today.
>
> Can you synchronize with the repository, to quickly find new changes?
>
> Erik.
>
>  ------------------------------
> *From:* Mark Smith [mailto:mar...@gm...]
> *Sent:* Sunday 12 October 2008 00:16
>
> *To:* Erik Vos
> *Subject:* Re: [Rails-devel] Haven't got the mail list stuff straight
>
>  Sure go ahead. I don't have commit rights to the CVS yet.
>
> On Sat, Oct 11, 2008 at 5:08 PM, Erik Vos <eri...@hc...> wrote:
>
>>  Mark,
>>
>> That is exactly what I did, except that I completely overlooked the other
>> use of WHICH_START_PRICE under your point 2!
>> I clearly need to regain some routine....   Thanks for pointing that one
>> out.
>> Shall I make that fix too or do you want to try it?
>>
>> Erik.
>>
>>
>>  ------------------------------
>> *From:* Mark Smith [mailto:mar...@gm...]
>> *Sent:* Saturday 11 October 2008 21:18
>> *To:* Erik Vos
>> *Subject:* Re: [Rails-devel] Haven't got the mail list stuff straight
>>
>>   OK, just to provide you my viewpoint of what needs to change, this is
>> what I suggest:
>>
>> 1. in the StartRoundWIndow.java routine,
>>     a. Add line just after setting compName "String playerName =
>> activeItem.getPlayerName();
>>     b. modify the line with "WHICH_START_PRICE" to be
>> "LocalText.getText("WHICH_START_PRICE", new String [] {playerName,
>> compNazme}),
>> 2. in the GameStatus.java routine,
>>    a. Add a line after setting the companyName to null, to be "String
>> playerName = "";
>>    b. Add a line after setting the 'cert' to be "playerName =
>> buy.getPlayerName ();
>>    c. modify the line with "WHICH_START_PRICE" to be
>> "LocalText.getText("WHICH_START_PRICE", new String [] {playerName,
>> compNazme}),"
>> 3.in the LocalisedText.properties, change the WHICH_START_PRICE line to
>> "WHICH_START_PRICE={0} please select the {1} start price:
>>
>> How does that line up with yours?
>>
>> Mark
>>
>> On Sat, Oct 11, 2008 at 12:28 PM, Erik Vos <eri...@hc...> wrote:
>>
>>>
>>> I would suggest a "minor" improvement to the UI when setting a Share
>>> Price...
>>>
>>> In the Dialog Box asking for the Share Price, given it is "Tom" who is
>>> setting the share price, say "Tom set the Share Price for B&O". It would
>>> make it clear in Hot Seat Games, WHO is expected to set the price. I will
>>> look to see if I can determine how to do that as and provide feedback.
>>>
>>> I fully agree. I apologise for already having done it - I overlooked your
>>> last sentence until I had already committed this (very simple) change. I
>>> hope I can restrain myself on your next excellent proposal... ;-)
>>>
>>>
>>
>