Menu
▾
▴
Re: [Rails-devel] Haven't got the mail list stuff straight
|
From: Erik V. <eri...@hc...> - 2008-10-11 17:29:03
|
I would suggest a "minor" improvement to the UI when setting a Share Price... In the Dialog Box asking for the Share Price, given it is "Tom" who is setting the share price, say "Tom set the Share Price for B&O". It would make it clear in Hot Seat Games, WHO is expected to set the price. I will look to see if I can determine how to do that as and provide feedback. I fully agree. I apologise for already having done it - I overlooked your last sentence until I had already committed this (very simple) change. I hope I can restrain myself on your next excellent proposal... ;-) More generally, I think there is a need for a better way to indicate which player has the turn. Now we only have the yellow background for the player name. Even more generally, I personally consider the current UI as more or less provisional. I have worked a lot on it because without a UI there is no game to play, but my personal emphasis is to get the back-end game engine right. I'm not a UI designer. A while ago someone proposed to create an Eclipse-based UI, and we have made room for that by moving all existing UI code below the ui.swing tree, but nothing has happened since. I can understand not wanting to change it again, if you have a solution ready at hand. It just seemed a bit awkward they way you have it organized currently. Perhaps, yes. As said, it was not easy to accomplish, and this code has gone through several phases. It's very well possible certainly don't exclude that it can be improved, but frankly I don't quite see your point. As far as I know the price must be set as soon as a player acquires the private together with the B&O president's share. That is what currently happens. It's a separate action because the price setting player may be different from the last acting one (as in the case you reported). Since I have resolved the issue of getting it to load, compile and run in debug mode on my Mac OSX, XCode environment, I will write up the steps I took to get it that far, and include a XCode version of the build.xml (a bit different from your eclipse version). I will look into some of the tile lay bugs reported in the bugs list to see what could be done about that. This will allow me to understand more about how your code handles the map, tile lays, promotions, and token placements. I haven't looked into the bugs list for a while, and I see there's a lot of new entries (which is good). A while ago I fixed some 18AL tile laying bugs, but I don't know if that fix covers the reported issue. Please go ahead looking into those bugs. Meanwhile I will start looking at some of the other reported bugs. I haven't worked seriously on this project for about half a year, and I'm trying to collect the courage for a restart. I've found before that fixing some bugs may well increase my appetite to start off with some new developments.... Erik. As for incorporating my Map/Tile drawing product, I still need to work out a detailed plan, but my initial thoughts would be to start by implementing a version of my "Tile Drawer" that could be done and not impact the existing map drawing abilities. The only possible downside is that my Tile Definitions files are somewhat different than those your system uses. And I do know that you do make use of the TIle Designer results, which I do not. But there may be a happy middle ground. Mark On Fri, Oct 10, 2008 at 3:02 PM, Erik Vos <eri...@hc...> wrote: I have fixed the (my) stupid 1851 cash assigment error, and the B&O private mishandling in 1830 (just two missing statements). The B&O private was actually one of the hardest things to get right when we completed 1830, and it apparently has since fallen victim to one of my many code reorganizations. (I'm not really in favour of changing that code yet another time...) Thanks for the good catch. Erik. > -----Original Message----- > From: Brett Lentz [mailto:wak...@gm...] > Sent: Thursday 09 October 2008 01:54 > To: Mark Smith > Cc: rai...@li... > Subject: Re: [Rails-devel] Haven't got the mail list stuff straight > > On Wed, 2008-10-08 at 19:40 -0500, Mark Smith wrote: > > Brett, > > > > For the Rails Developement Mailing List, what is the proper e-mail > > address to address messages to so that it gets added to the mailing > > list? > > > > I have looked over the Rails Bug List, and have at least one simple > > fix to the following: > > > > In the Bug Reports on Source Forge there is a report [1945662] 1851 > > starting cash wrong. The Solution is straight forward by correcting > > the 1851 data file under 'data/1851/Game.xml' to update the Players > > Tags as follows: > > > > Currently reads as: > > 15 <Component name="Bank" class="rails.game.Bank"> > > > > > > 16 <Bank amount="8040"/> > > 17 <Players number="3" cash="400" certLimit="10"/> > > > > > > 18 <Players number="4" cash="430" certLimit="12"/> > > > > 19 <Players number="5" cash="500" certLimit="15"/> > > > > > > 20 <Money format="$@"/> > > 21 </Component> > > > > > > To Be: > > > > 15 <Component name="Bank" class="rails.game.Bank"> > > > > > > 16 <Bank amount="8040"/> > > 17 <Players number="3" cash="500" certLimit="10"/> > > > > > > 18 <Players number="4" cash="430" certLimit="12"/> > > > > 19 <Players number="5" cash="400" certLimit="15"/> > > > > > > 20 <Money format="$@"/> > > 21 </Component> > > > > > > Per the Rule Book (or at least per Blackwater Station, > > http://18xx.net/1851/1851r008.txt) states: > > > > The number of Private Companies in the game is equal to the > number of > > > > players. If there are only three players use the L&O, M&C, > and ET&WNC. > > If there is a fourth player, add the O&W. If there is a > fifth player, > > > > add the CNO&TP. Set aside any unused Private Companies. > Distribute the > > > > starting capital to each player ($500 for 3 players, $430 > for 4 players, > > or $400 for 5 players). > > I have also been looking at the bug in 1830 about the B&O Private > > Company being sold for $0 whether bought outright, or bought via > > bidding. If bid on by two or more players, then the last > one to pass > > actually gets B&O for $0, rather then the high bidder. > Looking at the > > code it appears that since B&O Public Company needs a share > price set, > > it sets that flag, and does not sell B&O Private for the right price > > to the actual purchaser. And in the Bidding, the PASS > action sets the > > flag, rather than assigning it to the highest bidder for the proper > > bid price. But changing it there to always assign to the proper > > purchaser does not trigger the Price Setting of the Public Company. > > > > Logically to me it makes more sense to set the Share Price when the > > President's share is transferred to the new President, > unless there is > > already a Par Share Price set. Let the Bidding Process upon the last > > PASS, actually complete the Private Company Sale & Transfer. And if > > straight purchase (no bid, or single bid) then Sale & Transfer be > > performed. Only as a "after sale" Possible Action be to set > President > > Share transfer, and subsequent Par Value setting occur before the > > first Stock Round. > > > > I am just not familiar enough with the code yet to get all > the various > > patches together yet for you. And what I suggest is some significant > > code refactoring required. > > > > Mark Smith > > > > Mark - > > The address to use is rai...@li.... I'll cc my > reply to the list. > > The xml fix is fairly straightforward, and should relatively easy to > generate a diff for that. > > As for the B&O issue. I think Erik can speak more knowledgeably about > how that area of the code works. I suspect that with the current > refactoring that I'm doing, once I am ready to work on the game code > itself, I'll have some thoughts on how that stuff should work. > > > ---Brett. > > Avoid the Gates of Hell. Use Linux > -- unknown source > > > -------------------------------------------------------------- > ----------- > This SF.Net email is sponsored by the Moblin Your Move > Developer's challenge > Build the coolest Linux based applications with Moblin SDK & > win great prizes > Grand prize is a trip for two to an Open Source event > anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100 <http://moblin-contest.org/redirect.php?banner_id=100&url=/> &url=/ > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
