Re: [Rails-devel] Haven't got the mail list stuff straight

[Brett L. <wak...@gm...>]

On Wed, 2008-10-08 at 19:40 -0500, Mark Smith wrote:
> Brett,
> 
> For the Rails Developement Mailing List, what is the proper e-mail
> address to address messages to so that it gets added to the mailing
> list?
> 
> I have looked over the Rails Bug List, and have at least one simple
> fix to the following:
> 
> In the Bug Reports on Source Forge there is a report [1945662] 1851
> starting cash wrong. The Solution is straight forward by correcting
> the 1851 data file under 'data/1851/Game.xml' to update the Players
> Tags as follows:
> 
> Currently reads as:
> 15 	<Component name="Bank" class="rails.game.Bank">
> 
> 
>    16 		<Bank amount="8040"/>
>    17 		<Players number="3" cash="400" certLimit="10"/>
> 
> 
>    18 		<Players number="4" cash="430" certLimit="12"/>
> 
>    19 		<Players number="5" cash="500" certLimit="15"/>
> 
> 
>    20 		<Money format="$@"/>
>    21 	</Component>
> 
> 
> To Be:
> 
>    15 	<Component name="Bank" class="rails.game.Bank">
> 
> 
>    16 		<Bank amount="8040"/>
>    17 		<Players number="3" cash="500" certLimit="10"/>
> 
> 
>    18 		<Players number="4" cash="430" certLimit="12"/>
> 
>    19 		<Players number="5" cash="400" certLimit="15"/>
> 
> 
>    20 		<Money format="$@"/>
>    21 	</Component>
> 
> 
> Per the Rule Book (or at least per Blackwater Station,
> http://18xx.net/1851/1851r008.txt) states:
> 
> The number of Private Companies in the game is equal to the number of
> 
> players.  If there are only three players use the L&O, M&C, and ET&WNC.
> If there is a fourth player, add the O&W.  If there is a fifth player,
> 
> add the CNO&TP.  Set aside any unused Private Companies.  Distribute the
> 
> starting capital to each player ($500 for 3 players, $430 for 4 players,
> or $400 for 5 players).
> I have also been looking at the bug in 1830 about the B&O Private
> Company being sold for $0 whether bought outright, or bought via
> bidding. If bid on by two or more players,  then the last one to pass
> actually gets B&O for $0, rather then the high bidder. Looking at the
> code it appears that since B&O Public Company needs a share price set,
> it sets that flag, and does not sell B&O Private for the right price
> to the actual purchaser. And in the Bidding, the PASS action sets the
> flag, rather than assigning it to the highest bidder for the proper
> bid price. But changing it there to always assign to the proper
> purchaser does not trigger the Price Setting of the Public Company.
> 
> Logically to me it makes more sense to set the Share Price when the
> President's share is transferred to the new President, unless there is
> already a Par Share Price set. Let the Bidding Process upon the last
> PASS, actually complete the Private Company Sale & Transfer. And if
> straight purchase (no bid, or single bid) then Sale & Transfer be
> performed. Only as a "after sale" Possible Action be to set President
> Share transfer, and subsequent Par Value setting occur before the
> first Stock Round.
> 
> I am just not familiar enough with the code yet to get all the various
> patches together yet for you. And what I suggest is some significant
> code refactoring required. 
> 
> Mark Smith
> 

Mark -

The address to use is rai...@li.... I'll cc my
reply to the list. 

The xml fix is fairly straightforward, and should relatively easy to
generate a diff for that.

As for the B&O issue. I think Erik can speak more knowledgeably about
how that area of the code works. I suspect that with the current
refactoring that I'm doing, once I am ready to work on the game code
itself, I'll have some thoughts on how that stuff should work. 


---Brett.

Avoid the Gates of Hell.  Use Linux
	-- unknown source