Re: [Rails-devel] Reformatting

[Erik V. <eri...@hc...>]

I have changed the reformatting rules such, that lines will not be broken on
dots.
In case we want to split a long dot chain anyway, we can use the // trick
mentioned below. 

After picking up the latest patches, I have just reformatted and committed
everything.
So please refresh your sources!

Erik.

> -----Original Message-----
> From: Erik Vos [mailto:eri...@hc...] 
> Sent: Sunday 01 June 2008 14:57
> To: 'Development list for Rails: an 18xx game'
> Subject: Reformatting
> 
> I have reformatted all sources, but so far I have only 
> committed GameStatus_18EU and StatusWindow_18EU as (pretty 
> random) examples.
> 
> As I expected, automatic reformatting does no good on 
> wrapping long statements. 
> For some reason, Eclipse considers dots to be the most 
> preferrable line break points, rather than equals signs and 
> commas, as I would expect and prefer. And I see no way to 
> change that. 
> See StatusWindow_18EU: on lines 59-60 I get
>                     options[i] = LocalText.getText("N_Train", 
> trains.get(i)
>                             .getName());
> whereas it seems a lot more logical to me to make it like
>                     options[i] = LocalText.getText("N_Train",
> 				    trains.get(i).getName());
> This can in fact be achieved and retained by manually 
> inserting // at the preferred wrapping points,
> and as an example I have done that in the other committed 
> class, GameStatus_18EU.
> But it is a bit ugly, and it will probably never be completed 
> (as least not by me).
> 
> Any comments or suggestions before I proceed checking in (or 
> maybe undoing) the whole bunch?
> 
> Erik Vos
>