Re: [Rails-devel] Patchfiles

[Brett L. <wak...@gm...>]

On Wed, 2008-06-04 at 00:20 +0200, Freek Dijkstra wrote:
> Sorry to bother you, but it seems part of my patch went wrong.
> One of the modifications was made on the wrong line.
> 
> http://rails.cvs.sourceforge.net/rails/18xx/rails/ui/swing/hexmap/GUIHex.java?revision=1.16&view=markup
> Now reads:
> 
>    799 		if (getHexModel().getDestinations() != null) {
>    800 			tt.append("<br><b>Destination</b>:");
>    801 			for (PublicCompanyI dest : getHexModel().getDestinations()) {
>    802 			    tt.append("</html>");
>    803                 tt.append(dest.getName());
>    804 			}
>    805 		}
> 
> This is wrong: the tt.append("</html>"); should be outside the for loop.
> (and the remove tt.append(" "); should be restored)
> 
> So it should read:
> 
>    799 	    if (getHexModel().getDestinations() != null) {
>    800 	        tt.append("<br><b>Destination</b>:");
>    801 	        for (PublicCompanyI dest : 
> getHexModel().getDestinations()) {
>    802 	            tt.append (" ");
>    803               tt.append(dest.getName());
>    804 	        }
>    805 	    }
>    806 	    tt.append("</html">);
>    807 	    toolTip = tt.toString();
>    808 	}
>    809
> 
> This was my fault: my diff file was in error; it seems I accidentally 
> sent a diff between two working copies, instead of a diff between a 
> working copy and the repository.
> 
> I like to blame CVS this time (I'm used to svn).
> 
> I just manually verified all other commits (including those from last 
> weeks commit) and all other files are fine.
> 
> Sorry,
> Freek
> 



Fixed checked in.   Thanks for double-checking. :-)


---Brett.