Re: [Rails-devel] Patchfiles

[Erik V. <eri...@hc...>]

> On Sun, May 25, 2008 at 1:42 PM, Erik Vos <eri...@hc...> wrote:
> > Hi Freek,
> >
> > Welcome to the club! Your patch looks useful to me, but 
> I'll leave it to
> > Brett to incorporate it.
> 
> It looks good to me, but I'm not going to have a chance to merge it
> until mid-week. Erik, if you want to merge it sooner, feel free.

Here I must confess, that I have never taken the trouble so far to sort out
how to deal with such patches... :-(
 
> > Coding rules: I have written most of the code, and am using 
> 4-space indents.
> > Things go wrong when Brett reformats with his (I believe) 
> 3-space indents
> > ... ;-)
> > Indeed we have never settled that and it sometimes looks 
> ugly. I propose 4
> > spaces....
> > (Tabs or spaces: does it matter? Should I care? Not sure 
> how to control it).
> >
> 
> Yes.  4 space indents, expand tab characters to spaces is fine by me.

My current setting is 4 with tabs, but in fact I almost never reformat, 
because the formatter tends to break lines in ways I don't like.
I'm pretty good at formatting manually (he boasted), but no doubt
tabs and spaces get mixed this way.

But I agree that it's time to sort this out. 

Erik.