Re: [Rails-devel] Patchfiles

[brett l. <wak...@gm...>]

On Sun, May 25, 2008 at 3:08 PM, Freek Dijkstra <sf_...@ma...> wrote:
> Erik Vos wrote:
>
>> Coding rules: I have written most of the code, and am using 4-space indents.
>> Things go wrong when Brett reformats with his (I believe) 3-space indents
>> ... ;-)
>> Indeed we have never settled that and it sometimes looks ugly. I propose 4
>> spaces....
>> (Tabs or spaces: does it matter? Should I care? Not sure how to control it).
>
> I don't care, as long as it is consistent.
>
> Let's look at the statistics of *.jave files in the rails directory:
>
> 39194 lines of code
> 30748 lines with some sort of indentation
>
> 2542 lines combining tabs and 2 or more spaces
> (That should exclude lines with extra space to indent /* */ comments)
>
> 18245 lines with tabs only
> 9825  lines with spaces only
>
> 69 lines with 3 spaces
> 4008 line with 4 spaces
> 82 lines with 5 spaces (huh?)
> 53 lines with 6 spaces
> 68 lines with 7 spaces
> 2404 lines with 8 spaces
> 43 lines with 9 spaces
> 1 line with 10 spaces
> 54 lines with 11 spaces
> 1442 lines with 12 spaces
> etc
>
> So it seems most popular is tabs, then 4-spaces, then 3-spaces.
>

Yep. It's pretty grotty.  Feel free to send in a cleanup patch, if you like.

---Brett.