Re: [Rails-devel] Patchfiles

[brett l. <wak...@gm...>]

On Sun, May 25, 2008 at 1:42 PM, Erik Vos <eri...@hc...> wrote:
> Hi Freek,
>
> Welcome to the club! Your patch looks useful to me, but I'll leave it to
> Brett to incorporate it.

It looks good to me, but I'm not going to have a chance to merge it
until mid-week. Erik, if you want to merge it sooner, feel free.

> Coding rules: I have written most of the code, and am using 4-space indents.
> Things go wrong when Brett reformats with his (I believe) 3-space indents
> ... ;-)
> Indeed we have never settled that and it sometimes looks ugly. I propose 4
> spaces....
> (Tabs or spaces: does it matter? Should I care? Not sure how to control it).
>

Yes.  4 space indents, expand tab characters to spaces is fine by me.

I must apologize for this, as its entirely my fault.  I work from a
couple different machines and haven't been consistent about my
formatting settings.

In general, please just follow typical Java conventions.

> Submissions: start with sending patches like these. In some stage Brett may
> give you commit access.
>

My rule of thumb is submit around 4-5 patches, and then I'm usually
seen enough of your work to be comfortable allowing you to commit
directly.

> Erik Vos

---Brett.