Re: [Rails-devel] Patchfiles

[Erik V. <eri...@hc...>]

Hi Freek,

Welcome to the club! Your patch looks useful to me, but I'll leave it to
Brett to incorporate it.

Coding rules: I have written most of the code, and am using 4-space indents.
Things go wrong when Brett reformats with his (I believe) 3-space indents
... ;-)
Indeed we have never settled that and it sometimes looks ugly. I propose 4
spaces....
(Tabs or spaces: does it matter? Should I care? Not sure how to control it).

Submissions: start with sending patches like these. In some stage Brett may
give you commit access.

For what it's worth, some initial comments about your further suggestions:

> how many trains the bank still has, 

You can see that in the GameStatus window. The subject of duplicating more
info from there into the OR window is coming up regularly. I'm not very much
in favour of that, as the OR window is already overcrowded - at least at my
resolution it often gets higher than my screen, so that I must scroll the
map. In the past we had it split into two windows, and I'm not convinced
that it was a good move to combine these.

But perhaps you actually meant putting the number into the text of the Buy
Train popup selction box. That's OK, but it's not as trivial a change as it
seems.

> the 
> upgrade value 
> of a city while laying a tile, 

E.g. as a tooltip for the upgrade tiles at the left-hand side of the map?
Good idea.

> stricter tile-laying rules 
> -companies can 
> now place unreachable tile-, 

... and tokens, yes. The concept of 'routes' (or just 'reachability') has
not been implemented yet. IMO it's not a 'minor' change.

> saving of preferences between games, 

What preferences? I can imagine a UI to manage my.properties might come in
handy, althoug I wouldn't consider it a priority.

> unlimited tiles -a variant I prefer to play-, 

Currently we only have per-game variants/options, but this one would qualify
as a useful generic option, perhaps to be put in my.properties. 

> perhaps even automatic 
> route calculation)
 
... and revenues, I suppose you mean... Sure we want that, but this is
definitely not a minor update....

Best regards,
Erik Vos