Re: [Rails-devel] fix to bug 1870539

[Erik V. <eri...@hc...>]

I have found and fixed another bug that manifested itself in 18AL:
tiles with different internal and external IDs could not be laid,
like the Elyton/Birmingham yellow tile.

I have also added an "unfloated" (U) indicator to the GameStatus window for
companies that have been started but not yet floated: the President's
share percentage field now shows e.g. "30%PU" as long as that condition
exists.
The reason is that in games like 18EU you can't use the presence or absence 
of treasury money to see if a company has floated or not.

The main news is, that in 18EU you can now start a company by converting a
Minor, 
and fold in other Minors to already started companies as long as the latter
haven't operated. 

Most of the typical 18EU features have now been implemented.
The main missing ones are the final Minor exchange round and the Pullmann
trains.
I have upgraded the 18EU status in GamesList.xml to "Partly playable".

And now I really have to start doing taxes...

Erik.

> -----Original Message-----
> From: rai...@li... 
> [mailto:rai...@li...] On Behalf 
> Of brett lentz
> Sent: Tuesday 19 February 2008 03:22
> To: Development list for Rails: an 18xx game
> Subject: Re: [Rails-devel] fix to bug 1870539
> 
> On Feb 18, 2008 2:52 PM, Michał Bażyński <ba...@tl...> wrote:
> >
> > first of, how to reproduce the bug:
> >
> > In 18AL, conduct a start round in such a way that there's only one
> > bidder for the last private company. you can have every one make a
> > single bid on a different private for example, then buy 
> Tusc. Result:
> > the application hangs.
> >
> > Reason:
> >    in StockRound_1830.java in setPossibleActions() there's 
> a check if
> > there are any unsold companies left before each item is 
> looked at to see
> > if it is just auto-sold as there's only one bidder for it.
> >
> > Solution:
> >    add the extra check if any unsold privates remain after 
> looking at
> > them all.
> >
> > Attached is a patch doing just that.
> >
> > (My first patch, if I should be doing something differently 
> please tell me.)
> >
> > best regards,
> >    mike
> >
> > ? patch.txt
> > Index: StartRound_1830.java
> > ===================================================================
> > RCS file: /cvsroot/rails/18xx/rails/game/StartRound_1830.java,v
> > retrieving revision 1.11
> > diff -u -r1.11 StartRound_1830.java
> > --- StartRound_1830.java        13 Feb 2008 19:59:03 -0000      1.11
> > +++ StartRound_1830.java        18 Feb 2008 22:43:38 -0000
> > @@ -143,7 +143,13 @@
> >                                 }
> >
> >                         }
> > -
> > +
> > +            /*
> > +             * it is possible that the last unsold item 
> was sold in the above loop.
> > +             * go to next round if that happened
> > +             */
> > +            if (StartPacket.getStartPacket().areAllSold()) 
> return false;
> > +
> >                         if (possibleActions.isEmpty()) {
> >                                 numPasses.add(1);
> >                                 if 
> (auctionItemState.getObject() == null) {
> >
> 
> 
> 
> Applied.  Thanks!
> 
> ---Brett.
> --------------------------------------------------------------
> -----------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>