[R-gregmisc-users] SF.net SVN: r-gregmisc:[1792] trunk/gdata/tests/unitTests/runit.unknown.R

[<wa...@us...>]

Revision: 1792
          http://sourceforge.net/p/r-gregmisc/code/1792
Author:   warnes
Date:     2014-04-05 15:55:48 +0000 (Sat, 05 Apr 2014)
Log Message:
-----------
Apply changes Brian recommned to NAtoUnknown as well as unknownToNA.

Modified Paths:
--------------
    trunk/gdata/tests/unitTests/runit.unknown.R

Modified: trunk/gdata/tests/unitTests/runit.unknown.R
===================================================================
--- trunk/gdata/tests/unitTests/runit.unknown.R	2014-04-05 14:40:08 UTC (rev 1791)
+++ trunk/gdata/tests/unitTests/runit.unknown.R	2014-04-05 15:55:48 UTC (rev 1792)
@@ -249,7 +249,42 @@
   ## Date-time classes
   checkIdentical(isUnknown(xDateUnk, unknown=dateUnk), xDateTest)
   checkIdentical(isUnknown(xDate1Unk, unknown=dateUnk), xDate1Test)
-  checkIdentical(isUnknown(xPOSIXltUnk, unknown=POSIXltUnk), xPOSIXltTest)
+
+  ####
+  ## Per Brian Ripley on 2014-01-15:
+  ##
+  ## On platforms where POSIXlt has a gmtoff component, it does not
+  ## need to be set.  So
+  ##
+  ## > z$gmtoff
+  ## [1] 3600   NA
+  ## > xPOSIXltUnk$gmtoff
+  ## [1] 3600 3600
+  ##
+  ## (or sometimes 0, not NA).
+  ##
+  ## So although identical() correctly reports that they differ, this
+  ## is allowed for optional components.
+  ##
+  ## It would also be wrong to use identical() to compare isdst
+  ## components: isdst = -1 means unknown.
+  ##
+  ## Replaced:
+  ##    checkIdentical(isUnknown(xPOSIXltUnk, unknown=POSIXltUnk), xPOSIXltTest)
+  ## With:
+  tmp_isUnknown <- isUnknown(xPOSIXltUnk, unknown=POSIXltUnk)
+  tmp_xPOSIXltTest   <- xPOSIXlt
+
+  tmp_isUnknown$gmtoff    <- NULL  # Remove $gmtoff to avoid comparison
+  tmp_xPOSIXltTest$gmtoff <- NULL
+
+  tmp_isUnknownisdst     <- NULL   # Remove $isdst to avoid comparison
+  tmp_xPOSIXltTest$isdst <- NULL
+
+  checkIdentical(tmp_isUnknown, tmp_xPOSIXltTest)
+  ##
+  ####
+
   checkIdentical(isUnknown(xPOSIXlt1Unk, unknown=POSIXltUnk), xPOSIXlt1Test)
   checkIdentical(isUnknown(xPOSIXctUnk, unknown=POSIXctUnk), xPOSIXctTest)
   checkIdentical(isUnknown(xPOSIXct1Unk, unknown=POSIXctUnk), xPOSIXct1Test)
@@ -333,6 +368,7 @@
   checkIdentical(unknownToNA(xDateUnk, unknown=dateUnk), xDate)
   checkIdentical(unknownToNA(xPOSIXctUnk, unknown=POSIXctUnk), xPOSIXct)
 
+  ####
   ## Per Brian Ripley on 2014-01-15:
   ##
   ## On platforms where POSIXlt has a gmtoff component, it does not need to be set.  So
@@ -350,6 +386,9 @@
   ## It would also be wrong to use identical() to compare isdst
   ## components: isdst = -1 means unknown.
   ##
+  ## Replaced:
+  ##   checkIdentical(unknownToNA(xPOSIXltUnk, unknown=POSIXltUnk), xPOSIXlt)
+  ## With:
   tmp_unknownToNA <- unknownToNA(xPOSIXltUnk, unknown=POSIXltUnk)
   tmp_xPOSIXlt   <- xPOSIXlt
 
@@ -360,8 +399,8 @@
   tmp_xPOSIXlt$isdst   <- NULL
 
   checkIdentical(tmp_unknownToNA, tmp_xPOSIXlt)
+  ####
 
-
   ## --- lists and data.frames ---
 
   ## with vector of single unknown values

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.