The QZXing v2.3 release is mainly the updated of the zxing sources due to the zxing v2.3 release (https://github.com/zxing/zxing/releases/tag/zxing-2.3.0).
The API of QZXing remains unchanged.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Great work on the QML API. It's easy to use and adapts to a lot of use cases. :)
I've partially revisited the code to completely drop declarative package in Qt 5 build and I've modified the .pri to a .pro for lib generation. I've also revisited code to avoid compile errors in Android/iOS environments and everything seems to work fine.
I thought it would be fun to discuss with you possibile integration of (part of) these modications. Obviously, if it can be of interest to you.
Cheers,
F.
Last edit: BaCaRoZzo 2015-02-17
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Small bugfix for error created at e317c87 commit. ciw must not be deleted because it released by Ref in destructor. (in function QString QZXing::decodeImage(QImage &image, int maxWidth, int maxHeight, bool smoothTransformation))
I don't know how but I've NOT been updated on these messages. I just read them today.
Well, I'll download the updated version with the bugfixes and start from that.
Thanks for the opportunity to contribute. :)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
The QZXing v2.3 release is mainly the updated of the zxing sources due to the zxing v2.3 release (https://github.com/zxing/zxing/releases/tag/zxing-2.3.0).
The API of QZXing remains unchanged.
Hi Nikolaos.
Great work on the QML API. It's easy to use and adapts to a lot of use cases. :)
I've partially revisited the code to completely drop declarative package in Qt 5 build and I've modified the .pri to a .pro for lib generation. I've also revisited code to avoid compile errors in Android/iOS environments and everything seems to work fine.
I thought it would be fun to discuss with you possibile integration of (part of) these modications. Obviously, if it can be of interest to you.
Cheers,
F.
Last edit: BaCaRoZzo 2015-02-17
Also, if it is easier for you, you can send me the changes (the diff file) and i will review it.
Hello BaCaRoZzo!
Contributions are always welcomed! Could you make a fork and create a pull request from me to evaluate it? I gave you permissions to the repository.
(instructions can be found here: http://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#Forked-Public-Project)
Thank you for your help!
Small bugfix for error created at e317c87 commit. ciw must not be deleted because it released by Ref in destructor. (in function QString QZXing::decodeImage(QImage &image, int maxWidth, int maxHeight, bool smoothTransformation))
Thank you for your patch. It is now applied :)
Small fix for compiler warning: "Unpredictable behavior when deleting void*" on line "delete decoder;"
Good morning Alexxey,
i have added you as a developer to the project. Feel free to apply the patches yourself to the code :)
Last edit: Nikolaos Ftylitakis 2015-05-27
OK :) Thanks. I'll try it.
Hello once again,
it has been some time since the last time that you replied so i have already applied the patch that you have proposed https://sourceforge.net/p/qzxing/code/ci/a176fd841b494ebe270076389aad85cc10df024c/
In case you find any other bugs feel free to apply them yourself :)
Sorry for the mixup and thank you for your contribution!
I don't know how but I've NOT been updated on these messages. I just read them today.
Well, I'll download the updated version with the bugfixes and start from that.
Thanks for the opportunity to contribute. :)