Re: [Quickfixj-users] JPMS - split package issue

[Christoph J. <chr...@ma...>]

Hi Vlad,

thanks for your effort!
I prefer solution 1 (Generate a quickfixj-fields jar to be used as dependency by the other messages 
jars. This way the jar can be imported only once and split package issue is avoided.
Advantage: avoid code duplication, avoid split package issue).
It is also going to introduce the least hassle I think. Users then need to add just one additional 
dependency which should be fine.

BTW quickfixj-core also would need the quickfixj-fields.jar as dependency. Maybe this is also a 
problem. I don't know whether there may be circular dependencies between the core and fields module. 
IIRC with some field converters but maybe I am confusing something.

Cheers,
Chris.


On 24.09.19 08:41, vlad manuel wrote:
> Hi all,
>
> I have created the following Jira Ticket to keep track of the agreed solution before creating the 
> PR to fix split packages issue: [QFJ-987] JPMS: Change field classes generation to resolve split 
> package issue - QuickFIX/J Jira <https://www.quickfixj.org/jira/browse/QFJ-987>
>
> I have added there a comment with 2 possible solutions I'm considering. I'm looking forward for 
> your feedback!
>
> Thanks,
> Vlad
>
>
> Le jeudi 12 septembre 2019 à 11:13:21 UTC+3, Christoph John <chr...@ma...> a écrit :
>
>
> Hi Vlad,
>
> oh well, yes. This is one of the things that were done to get the dependencies in Maven right 
> IIRC. But I could be wrong, it was some years ago when this was done.
> However, please feel free the open a PR for this, very much appreciated. 
> https://github.com/quickfix-j/quickfixj/pulls
>
> I think all users appreciate if QFJ could be used with a recent Java version without issues.
>
> Thanks in advance and best regards
> Chris.
>
> On 12.09.19 09:55, vlad manuel via Quickfixj-users wrote:
>> QuickFIX/J Documentation:http://www.quickfixj.org/documentation/
>> QuickFIX/J Support:http://www.quickfixj.org/support/
>>
>>
>>
> Hi all,
>
> I'm trying to use quickfixj in a Java11 environment with the new java modules.
> However, I'm facing some split package issues.
> E.g., each version of quickfix messages contain the same "quickfix.fiels" package.
> So if I'm using two versions of messages in my module, I'm facing a split package issue which is 
> no longer tolerated by the jvm.
>
> I would like to create a PR for this. Looking forward to hearing your opinion on this topic.
>
> Thanks,
> Vlad Muresan
>
>
> _______________________________________________
> Quickfixj-users mailing list
> Qui...@li...  <mailto:Qui...@li...>
> https://lists.sourceforge.net/lists/listinfo/quickfixj-users
>
> -- 
> Christoph John
> Software Engineering
> T +49 241 557080-28
> chr...@ma...  <mailto:chr...@ma...>
>
> MACD GmbH
> Oppenhoffallee 103
> 52066 Aachen, Germany
> www.macd.com  <http://www.macd.com>
>
> Amtsgericht Aachen: HRB 8151
> Ust.-Id: DE 813021663
> Geschäftsführer: George Macdonald

-- 
Christoph John
Software Engineering
T +49 241 557080-28
chr...@ma...

MACD GmbH
Oppenhoffallee 103
52066 Aachen, Germany
www.macd.com

Amtsgericht Aachen: HRB 8151
Ust.-Id: DE 813021663
Geschäftsführer: George Macdonald