Re: [Quickfixj-users] QuickFIX/J 2.1.1 - SLF4J Log Categories appear incorrect

[Christoph J. <chr...@ma...>]

Thinking further about this I believe that you do not need that setting when you already name your 
categories e.g. "${senderCompID}.${targetCompID}." So setting it to N should be OK.
The only problem I see now is that the sessionID seems to be appended and not prepended.

Chris.

On 11/07/2019 10:24, Christoph John via Quickfixj-users wrote:
> QuickFIX/J Documentation: http://www.quickfixj.org/documentation/
> QuickFIX/J Support: http://www.quickfixj.org/support/
>
>
>
> Hi Tommy,
>
> sorry for the late reply.
> Just to understand: you were not specifying the setting SLF4JLogPrependSessionID=Y before? I mean 
> you shouldn't because its default seems to be Y.
> And when you now put SLF4JLogPrependSessionID=N then the behaviour is as before, i.e. with QFJ 1.6.3?
>
> Did the log filenames change or only the content of the files, i.e. the logger name?
>
> Cheers,
> Chris.
>
>
> On 26/04/2019 01:11, th...@ft... wrote:
>> QuickFIX/J Documentation:http://www.quickfixj.org/documentation/
>> QuickFIX/J Support:http://www.quickfixj.org/support/
>>
>>
>>
>> Has anybody with authority had a chance to look at this?  The change introduced has the presumed 
>> unintended consequences of breaking things for some of us using Log4J.
>>
>> Regards - Tommy
>>
>>> On Apr 10, 2019, at 10:26 PM, th...@ft... <mailto:th...@ft...> wrote:
>>>
>>> I recently downloaded QF/J 2.1.1 and am upgrading from QF/J 1.6.3.  Most of the work was 
>>> converting my application code to utilize the ‘java.time’ package.  I have everything running 
>>> and going thru some tests.  In the process, I noticed log messages in files they were not in 
>>> before.  We use Log4J and configure the following QF/J properties…
>>>
>>> SLF4JLogEventCategory=${senderCompID}.${targetCompID}.event
>>> SLF4JLogIncomingMessageCategory=${senderCompID}.${targetCompID}.msg.incoming
>>> SLF4JLogOutgoingMessageCategory=${senderCompID}.${targetCompID}.msg.outgoing
>>>
>>> ..and the recently discovered (not in the user manual)…
>>>
>>> SLF4JLogErrorEventCategory=${senderCompID}.${targetCompID}.errorEvent
>>>
>>> I have spent hours reviewing and comparing QF/J source code trying to determine what changed.
>>>
>>> It appears there is a configuration setting 'SLF4JLogPrependSessionID’ described as "Controls 
>>> whether session ID is prepended to log message.”
>>>
>>> The behavior of this setting has been completely changed by the following commit of source file 
>>> ‘SLF4JLog.java’...
>>>
>>> https://github.com/quickfix-j/quickfixj/commit/0eb3359059d3551dde588f3cff6c836119141cf6#diff-82a6b6a09255551e3683d8943e3e4263 
>>>
>>>
>>> It appears the intent of this change did not create the desired effect as my log “categories" 
>>> now all have the SessionID appended. (e.g. 'SENDER.TARGET.eventFIX.4.4:SENDER->TARGET: ')
>>>
>>> The current workaround is to configure... SLF4JLogPrependSessionID=N
>>>
>>> Would someone please elaborate on the intended use of configuration setting 
>>> ‘SLF4JLogPrependSessionID’.
>>>
>>> Regards - Tommy
>>
>>

-- 
Christoph John
Software Engineering
T +49 241 557080-28
chr...@ma...

MACD GmbH
Oppenhoffallee 103
52066 Aachen, Germany
www.macd.com

Amtsgericht Aachen: HRB 8151
Ust.-Id: DE 813021663
Geschäftsführer: George Macdonald