Re: [Quickfixj-users] QuickFIX/J 2.1.1 - SLF4J Log Categories appear incorrect

[<th...@ft...>]

Has anybody with authority had a chance to look at this?  The change introduced has the presumed unintended consequences of breaking things for some of us using Log4J.

Regards - Tommy

> On Apr 10, 2019, at 10:26 PM, th...@ft... wrote:
> 
> I recently downloaded QF/J 2.1.1 and am upgrading from QF/J 1.6.3.  Most of the work was converting my application code to utilize the ‘java.time’ package.  I have everything running and going thru some tests.  In the process, I noticed log messages in files they were not in before.  We use Log4J and configure the following QF/J properties…
> 
> SLF4JLogEventCategory=${senderCompID}.${targetCompID}.event
> SLF4JLogIncomingMessageCategory=${senderCompID}.${targetCompID}.msg.incoming
> SLF4JLogOutgoingMessageCategory=${senderCompID}.${targetCompID}.msg.outgoing
> 
> ..and the recently discovered (not in the user manual)…
> 
> SLF4JLogErrorEventCategory=${senderCompID}.${targetCompID}.errorEvent
> 
> I have spent hours reviewing and comparing QF/J source code trying to determine what changed.
> 
> It appears there is a configuration setting 'SLF4JLogPrependSessionID’ described as "Controls whether session ID is prepended to log message.”
> 
> The behavior of this setting has been completely changed by the following commit of source file ‘SLF4JLog.java’...
> 
> https://github.com/quickfix-j/quickfixj/commit/0eb3359059d3551dde588f3cff6c836119141cf6#diff-82a6b6a09255551e3683d8943e3e4263 <https://github.com/quickfix-j/quickfixj/commit/0eb3359059d3551dde588f3cff6c836119141cf6#diff-82a6b6a09255551e3683d8943e3e4263>
> 
> It appears the intent of this change did not create the desired effect as my log “categories" now all have the SessionID appended. (e.g. 'SENDER.TARGET.eventFIX.4.4:SENDER->TARGET: ')
> 
> The current workaround is to configure... SLF4JLogPrependSessionID=N
> 
> Would someone please elaborate on the intended use of configuration setting ‘SLF4JLogPrependSessionID’.
> 
> Regards - Tommy