|
From: Christoph J. <chr...@ma...> - 2018-11-21 12:51:30
|
Hi Alex, great, thank you. I will leave some comments on the pull request. https://github.com/quickfix-j/quickfixj/pull/216 Cheers, Chris. On 21/11/2018 13:42, Alex Wibowo wrote: > Hi Christoph, > > I have created a PR for this. Seems like changing 'sections' in SessionSettings fix the issue. I > have also created an end-to-end test on my project that I have configured to run overnight. So far > the result is looking positive with the change. > > Regards, > > Alex > > On Wed, Nov 21, 2018 at 11:00 PM Christoph John <chr...@ma... > <mailto:chr...@ma...>> wrote: > > Hi Alex, > > unfortunately I am out of ideas at the moment but there are two components which I cannot use > to reproduce the error. The first is Spring, the other one is Zing VM (according to your stack > traces). > Maybe you can also test to not inject the config by Spring but to construct and pass it > manually. I don't know which initialization guarantees Spring has nor how its internal thread > model works. To me this looks like a problem of visibility. So just for testing you could also > add "volatile" to all variables to see if the problem goes away. ;) > > Sorry for not being more helpful but to further analyse the issue we need a reproducer e.g. > unit test. > > Chris. > -- Christoph John Software Engineering T +49 241 557080-28 chr...@ma... MACD GmbH Oppenhoffallee 103 52066 Aachen, Germany www.macd.com Amtsgericht Aachen: HRB 8151 Ust.-Id: DE 813021663 Geschäftsführer: George Macdonald |