Re: [Quickfixj-users] SessionSettings gets cleared out

[Christoph J. <chr...@ma...>]

Hi Alex,

I meant that there was a bug in the old code that caused old sessions to be never cleaned up. But as 
you describe it, the case for you seems to be a different one.
Thanks for the additional information (ThreadedSocketAcceptor and 50 connections log in at the same 
time). That gives me another hint on where to look. I will report back as soon as I have an idea. 
But sounds to me like something is not initialized correctly when several threads access it.

I guess this has some overlaps with https://www.quickfixj.org/jira/browse/QFJ-963 .

Cheers,
Chris.



On 19/11/2018 20:00, Alex Wibowo wrote:
> Hi Christoph,
>
>
> Thank you again for your reply. I don’t quite understand what you meant by “old” dynamic session. 
> Did you mean it was actually a bug in 1.5.3, and behave properly in 2.1.0 ? For my case, the error 
> occurred during first time setup - I.e none of the session has not logged in before, and then 50 
> connections try to login at the same time..
> As far as I can tell, there is no call to the “removeSetting” on SessionSettings. So I am a bit 
> puzzled as to what could cause the settings to get cleared.
>
> Regards
>
> Alex
>
> On Tue, 20 Nov 2018 at 2:19 am, Christoph John <chr...@ma... 
> <mailto:chr...@ma...>> wrote:
>
>     Hi,
>
>     I heard recently that "old" dynamic sessions were not properly removed before QFJ 2.1.0. So
>     maybe this is a side effect of this. But just a wild guess though.
>     Anyway, please open a JIRA issue for this. Of course it would be the best if we could
>     reproduce it. :)
>
>     I briefly tested if this is a general problem but it does not seem likely. E.g. when I comment
>     line
>     https://github.com/quickfix-j/quickfixj/blob/fcee00fb1709bc3f1c62b9a893c0e38d873fd312/quickfixj-core/src/test/java/quickfix/mina/acceptor/DynamicAcceptorSessionProviderTest.java#L195
>     then the test fails with the error message "Missing ConnectionType". However, when I add
>
>     ownSettings.setString("ConnectionType", "acceptor");
>
>     , i.e. adding the ConnectionType to the DEFAULT section, the test passes.
>
>     Cheers,
>     Chris.
>

-- 
Christoph John
Software Engineering
T +49 241 557080-28
chr...@ma...

MACD GmbH
Oppenhoffallee 103
52066 Aachen, Germany
www.macd.com

Amtsgericht Aachen: HRB 8151
Ust.-Id: DE 813021663
Geschäftsführer: George Macdonald