Re: [Quickfixj-users] Similar issue to QFJ-592 but on the initiator side

[Aleksander F. <Ale...@ig...>]

Hello Chris,

Thank you kindly for your prompt answer!

I dug a little big deeper and the issue was fixed here:
https://github.com/quickfix-j/quickfixj/commit/f8442f6

Well, I guess its time to upgrade! :)


Thanks,
Aleksander Fular

From: Christoph John [mailto:chr...@ma...]
Sent: Thursday, May 24, 2018 2:17 PM
To: qui...@li...; Aleksander Fular <Ale...@ig...>
Cc: Marcin Byszewski <Mar...@ig...>
Subject: Re: [Quickfixj-users] Similar issue to QFJ-592 but on the initiator side

Hi,

this could very well be an issue, although no-one has reported it for Initiators. I guess only fixing it for the Acceptor was simply an oversight.

IMHO a JIRA issue is not needed if you submit a PR directly. It would be great if you could add a unit test also (in a similar manner as it was done for QFJ-592). If you need help just ask.
But please note that this can only be incorporated into 2.0.x and 2.x milestone. We will not do any backports. Just saying because you are using a rather old version of QFJ. ;)

Thanks in advance and best regards
Chris.

On 24/05/18 10:39, Aleksander Fular wrote:

QuickFIX/J Documentation: http://www.quickfixj.org/documentation/

QuickFIX/J Support: http://www.quickfixj.org/support/







Hello Quickfixj users,

I am currently using an Application that uses quickfix 1.5.3.

It seems that we have stumbled across an issue similar to the one mentioned in QFJ-592, however this one is on the initiator side.

The acceptor party that we connect to, sends us immediately a message after logon.
Because of that we are sometimes left with an error from quickfix:

Invalid message: Can't determine ApplVerID for message ...

This only happens when we receive the message very shortly after receiving logon.

I've taken a brief look at the code and the issue seems to be exactly the same as the issue fixed In QFJ-592 however this one is on the initiator side.
Where applVerId is set in the 'next(Message)' function,   - line 908 Session.java file - during processing messages in the queue
it is required to be present in the parse method - invoked from messageReceived  - AbstractIoHandler - and this is invoked before putting message to queue.



To me this looks exactly the same as issue solved in QFJ-592, and I am wondering why that change was only applied to Acceptor.

Can you guys please shed some light on this?
Is this issue fixed in different branches?
Is this something that you are aware of?

If this is indeed an issue, do you want me to raise an issue on your jira & do a PR?



Thanks,
Aleksander Fular



________________________________

The information contained in this email is strictly confidential and for the use of the addressee only, unless otherwise indicated. If you are not the intended recipient, please do not read, copy, use or disclose to others this message or any attachment. Please also notify the sender by replying to this email or by telephone (+44 (0)20 7896 0011) and then delete the email and any copies of it. Opinions, conclusions (etc) that do not relate to the official business of this company shall be understood as neither given nor endorsed by it. IG Group Holdings plc is a company registered in England and Wales under number 04677092. VAT registration number 761 2978 07. Registered Office: Cannon Bridge House, 25 Dowgate Hill, London EC4R 2YA. Listed on the London Stock Exchange. Its subsidiaries IG Markets Limited and IG Index Limited are authorised and regulated by the Financial Conduct Authority (IG Markets Limited FCA registration number 195355 and IG Index Limited FCA registration number 114059).-



------------------------------------------------------------------------------

Check out the vibrant tech community on one of the world's most

engaging tech sites, Slashdot.org! http://sdm.link/slashdot




_______________________________________________

Quickfixj-users mailing list

Qui...@li...<mailto:Qui...@li...>

https://lists.sourceforge.net/lists/listinfo/quickfixj-users



--

Christoph John

Software Engineering

T +49 241 557080-28

chr...@ma...<mailto:chr...@ma...>



MACD GmbH

Oppenhoffallee 103

52066 Aachen, Germany

www.macd.com<http://www.macd.com>



Amtsgericht Aachen: HRB 8151

Ust.-Id: DE 813021663

Geschäftsführer: George Macdonald