|
From: Chris H. <chr...@ho...> - 2006-12-13 18:01:23
|
<html><div style='background-color:'><DIV class=RTE> <P>Hi Steve,</P> <P>Annother class to be looked at for threading issues ..</P> <P>I'm investigating a connect \ reconnect problem I have and had to look at IoSessionInitator.java as part of this and that doesn't feel right. The actual problem I have may be something else but I'll have to consider this as it fits the symptoms.</P> <P>Only one method is synchronized , I think they all should be (easy fix) , I think it makes logical sense (i.e. blocks connection and disconnection from occuring at the same time) and it has its own thread (the reconnect task) so variables will be shared between at least two threads with out appropriate memory barriers and it shares a long member which is an extra no-no as long read \writes aren't guaranteed atomic operations.</P> <P>Apologies if I've missed some some synchronization that occurs somewhere else, (bound to happen eventually :-) )...</P> <P>Chris</P> <P>PS I've got a couple of extra nice to haves (minor fixes) I'll put through the proper channels as they are not thread related directly. <BR><BR></P></DIV> <DIV></DIV> <BLOCKQUOTE style="PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: #a0c6e5 2px solid; MARGIN-RIGHT: 0px"><FONT style="FONT-SIZE: 11px; FONT-FAMILY: tahoma,sans-serif"> <HR color=#a0c6e5 SIZE=1> <DIV></DIV>From: <I>"Steve Bate" <st...@te...></I><BR>Reply-To: <I>qui...@li...</I><BR>To: <I><qui...@li...></I><BR>Subject: <I>Re: [Quickfixj-users] SessionStatus question</I><BR>Date: <I>Wed, 6 Dec 2006 08:27:38 -0500</I><BR>>QuickFIX/J Documentation: http://www.quickfixj.org/documentation/<BR>>QuickFIX/J Support: http://www.quickfixj.org/support/<BR>><BR>>Hi Chris, Jörg, and Patrick,<BR>><BR>>I'll have limited time for development during the holidays, but I'll<BR>>start looking into the issues before then. I agree that the first place<BR>>to look is SessionState and Session. If I have time available, I'll<BR>>start making some of the changes and post a note on this list so people<BR>>can review the modified code.<BR>><BR>>Jörg, I'm open to a state machine implementation of the Session. For<BR>>this initial activity, I'd like to stay with the current design. One<BR>>advantage for me is that when Oren makes changes to the Session design<BR>>it's easier for me to merge into QFJ if the designs are similar.<BR>><BR>>Steve<BR>><BR>> > -----Original Message-----<BR>> > From: qui...@li... [mailto:quickfixj-<BR>> > use...@li...] On Behalf Of Chris Hurst<BR>> > Sent: Tuesday, December 05, 2006 7:19 AM<BR>> > To: qui...@li...<BR>> > Subject: Re: [Quickfixj-users] SessionStatus question<BR>> ><BR>> > QuickFIX/J Documentation: http://www.quickfixj.org/documentation/<BR>> > QuickFIX/J Support: http://www.quickfixj.org/support/<BR>> > Off course, I'll input as / if required with coding\ or looking at code,<BR>> > sessionstate in isolation a should be trivial to fix but session itself,<BR>> > if<BR>> > that was all that was required but it probably does require a bit more<BR>> > thought as regards state transition etc i.e. yes session does require<BR>> > some<BR>> > thought with regard to multi threading i.e. the session transitioning<BR>> > state<BR>> > while another thread is observing.<BR>> ><BR>> > Let me know when you have a plan of attack, or if you would like some<BR>> > input<BR>> > on formulating one.<BR>> ><BR>> > Chris<BR>> ><BR>> > _________________________________________________________________<BR>> > It's Hotmail's 10th Birthday! Come and play Pass the Parcel<BR>> > http://www.msnpasstheparcel.com<BR>> ><BR>> ><BR>> > -------------------------------------------------------------------------<BR>> > Take Surveys. Earn Cash. Influence the Future of IT<BR>> > Join SourceForge.net's Techsay panel and you'll get the chance to share<BR>> > your<BR>> > opinions on IT & business topics through brief surveys - and earn cash<BR>> > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV<BR>> > _______________________________________________<BR>> > Quickfixj-users mailing list<BR>> > Qui...@li...<BR>> > https://lists.sourceforge.net/lists/listinfo/quickfixj-users<BR>><BR>><BR>><BR>>-------------------------------------------------------------------------<BR>>Take Surveys. Earn Cash. Influence the Future of IT<BR>>Join SourceForge.net's Techsay panel and you'll get the chance to share your<BR>>opinions on IT & business topics through brief surveys - and earn cash<BR>>http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV<BR>>_______________________________________________<BR>>Quickfixj-users mailing list<BR>>Qui...@li...<BR>>https://lists.sourceforge.net/lists/listinfo/quickfixj-users<BR></FONT></BLOCKQUOTE></div><br clear=all><hr> <a href="http://g.msn.com/8HMAENUS/2749??PS=47575" target="_top">Talk now to your Hotmail contacts with Windows Live Messenger.</a> </html> |