quickfix-developers

[Quickfix-developers] [CVS] SocketException::errorToWhat doesn't return anything on non-Win32

[Caleb E. <cal...@gm...>]

From the latest QF CVS code:

/home/ietdev/tools/linux-i686-gcc/quickfix-CVS-20050225/include/quickfix/Exceptions.h:
In member function `std::string
FIX::SocketException::errorToWhat(int)':
/home/ietdev/tools/linux-i686-gcc/quickfix-CVS-20050225/include/quickfix/Exceptions.h:347:
warning: no return statement in function returning non-void

I think this branch of the code should return "strerror (error)"

-- 
Caleb Epstein
caleb dot epstein at gmail dot com

Re: [Quickfix-developers] [CVS] SocketException::errorToWhat doesn't return anything on non-Win32

[Joerg T. <Joe...@ma...>]

Hi Caleb,

>>From the latest QF CVS code:
> 
> /home/ietdev/tools/linux-i686-gcc/quickfix-CVS-20050225/include/quickfix/Exceptions.h:
> In member function `std::string
> FIX::SocketException::errorToWhat(int)':
> /home/ietdev/tools/linux-i686-gcc/quickfix-CVS-20050225/include/quickfix/Exceptions.h:347:
> warning: no return statement in function returning non-void
> 
> I think this branch of the code should return "strerror (error)"

Yes, it looks like the non-MS branch of this code looks a bit incomplete. IMHO, Oren 
should check this.

Cheers, Jörg

-- 
Joerg Thoennes
                                http://macd.com
Tel.: +49 (0)241 44597-24      Macdonald Associates GmbH
Fax : +49 (0)241 44597-10      Lothringer Str. 52, D-52070 Aachen