quickfix-developers

[Quickfix-developers] QF (acceptor) crash

[Alexey Z. <ale...@in...>]

Hello All,
=20
I=92ve got a crash (unhandled exception) in a server application.
Here is the scenario:
=20
I added a non required field (tag 50) to logon message and sent it by
mistake without value:
8=3DFIX.4.29=3D9635=3DA34=3D149=3DXXXX50=3D52=3D20050119-19:37:3=85..
=20
And I=92ve got a crash in the server =96 m_sessionID is not valid.
=20
=20
void Session::generateReject( const Message& message, int err, int field
)
{ QF_STACK_PUSH(Session::generateReject)
=20
  if ( !m_state.receivedLogon() )
    throw std::logic_error( "Tried to send a reject while not logged on"
);
=20
/***/// here is the crash
  std::string beginString =3D m_sessionID.getBeginString();
=20
=20
=20
Regards, Alexey.

[Quickfix-developers] SessionQualifier not copied properly for Java

[Scott H. <sco...@fo...>]

I started using the new SessionQualifier feature today (using JNI) and had
failures at first.  I tracked it down to the src/java/Conversions.h file, 
and the problem was pretty easy to fix.  Here is the patch:

diff -u -r1.16 Conversions.h
--- Conversions.h       3 Nov 2004 16:31:54 -0000       1.16
+++ Conversions.h       20 Jan 2005 19:44:02 -0000
@@ -69,16 +69,18 @@
 {
   JNIEnv * pEnv = ENV::get();
   JVMClass type( "Lquickfix/SessionID;" );
-  jmethodID method = pEnv->GetMethodID( type, "<init>", "(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;)V" );
+  jmethodID method = pEnv->GetMethodID( type, "<init>", "(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;)V" 
);
   
   jstring beginString = newString( sessionID.getBeginString().getValue() );
   jstring senderCompID = newString( sessionID.getSenderCompID().getValue() );
   jstring targetCompID = newString( sessionID.getTargetCompID().getValue() );
-  jobject result = pEnv->NewObject( type, method, beginString, senderCompID, targetCompID );
+  jstring qualifier = newString( sessionID.getSessionQualifier() );
+  jobject result = pEnv->NewObject( type, method, beginString, senderCompID, targetCompID, qualifier );
 
   pEnv->DeleteLocalRef( beginString );
   pEnv->DeleteLocalRef( senderCompID );
   pEnv->DeleteLocalRef( targetCompID );
+  pEnv->DeleteLocalRef( qualifier );
   return result;
 }
 

Re: [Quickfix-developers] SessionQualifier not copied properly for Java

[Joerg T. <Joe...@ma...>]

Scott Harrington wrote:
> I started using the new SessionQualifier feature today (using JNI) and had
> failures at first.  I tracked it down to the src/java/Conversions.h file, 
> and the problem was pretty easy to fix.  Here is the patch:

Thanks, Scott, for the patch. The bug has been fixed:

http://www.quickfixengine.org/bugtracker/bug.php?op=show&bugid=50

See CVS repository:

http://cvs.sourceforge.net/viewcvs.py/quickfix/quickfix/src/java/Conversions.h?r1=1.16&r2=1.17

Cheers, Jörg

-- 
Joerg Thoennes
                                http://macd.com
Tel.: +49 (0)241 44597-24      Macdonald Associates GmbH
Fax : +49 (0)241 44597-10      Lothringer Str. 52, D-52070 Aachen