[Quickfix-developers] Small bug in QF 1.9.0. Target and sender seq number.

[Guillermo A. A. <gar...@vi...>]

Hi guys!

I think I've found an small bug in this new QF release. As i'm still
developing i justinstall any new version that becomes available,  and =0D
i've
found that everytime i kill and start my application ( i do it =0D
gracefully
with acceptor.stop() ) the expected incoming seq number for every =0D
session
becomes 2004. I'm using MySQL storage and logging.

I've done a little research and i think that in
MySQLStore::PopulateCache(...) its the mistake:

(...)
      MYSQL_ROW row =3D mysql_fetch_row( result );
      UtcTimeStamp time;
      std::string sqlTime =3D row[ 3 ];
      strptime( sqlTime.c_str(), "%Y-%m-%d %H:%M:%S", time );
      static_cast<tm*>(time)->tm_isdst =3D -1;
      m_cache.setCreationTime( time );
      m_cache.setNextTargetMsgSeqNum( atol( row[ 4 ] ) );
      m_cache.setNextSenderMsgSeqNum( atol( row[ 5 ] ) );
(...)

since the sessions table now has a new column before the seq num ones, i
think cache seq nums must be populated from row[5] and row [6].

Beyond this being the solution, i think an acceptance test that covers =0D
this
kind of things is missing, but dont really know how hard would it be to
write it, since it should kill the process and start it again.

Anyway, cheers again for such good work!


Guillermo Arbeiza
=0D
=0D
****************************** AVISO LEGAL =0D
******************************

La informaci=C3=B3n contenida en este mensaje es para uso exclusivo de su=
 =0D
destinatario. No debe copiarse, transmitirse a terceros ni guardarse por =
=0D
estos =C3=BAltimos, salvo autorizaci=C3=B3n del remitente.

Puede contener informaci=C3=B3n confidencial o legalmente protegida cuyo =
=0D
r=C3=A9gimen legal de utilizaci=C3=B3n no se ve afectado por el hecho de =
que =0D
haya sido enviada por correo electr=C3=B3nico.

Su env=C3=ADo por error a una persona distinta de su destinatario real no=
 =0D
implica que se haya modificado tal destinatario ni supone renuncia a su =0D
eventual car=C3=A1cter confidencial o al r=C3=A9gimen legal que rija su =0D
utilizaci=C3=B3n.

Cualquier opini=C3=B3n expresada en este mensaje vincular=C3=A1 exclusiva=
mente a =0D
la persona que lo haya remitido, excepto cuando el mensaje establezca lo =
=0D
contrario y el remitente est=C3=A9 autorizado para establecer que dichas =
=0D
opiniones vincular=C3=A1n a esta entidad.=20

En el supuesto de que este correo se recibiera por error, rogamos =0D
procedan a borrarlo, sin reenviarlo a terceros ni conservarlo en =0D
cualquier soporte y nos informen inmediatamente llamando al tel=C3=A9fono=
 34 =0D
91 5892123 o a la direcci=C3=B3n de correo electr=C3=B3nico remitente. Gr=
acias.

****************************** DISCLAIMER ******************************

The information contained in this message is for the exclusive use of =0D
the named person. It can not be copied, transmitted to third parties or =0D
stored by the latter, except if authorised by the sender.

It may contain confidential or legally privileged information whose =0D
legal regime is not affected by the fact that this information has been =0D
sent by e-mail.=20

Its erroneous transmission to a person other than the real named person =0D
neither implies any modification of this named person nor a renunciation =
=0D
of the eventual confidentiality or legal regime affecting the use of =0D
concerned message.
=20
Any views expressed in this message are binding exclusively upon the =0D
individual sender, except where the message states otherwise and the =0D
sender is authorised to bind this entity.=20

If you receive this message in error, please delete it without =0D
transmitting it to any third party or keeping it in any form and notify =0D
us immediately either by phone (34 91 5892123) or using the e- mail =0D
address of the sender. Thank You.=0D