Re: [Quickfix-developers] Details for Solaris / SunPRO 5.3 build

[Oren M. <or...@qu...>]

Ok,

I've taken care of most of these in CVS (haven't messed with the build 
files yet).

- The macros now do not contain ending semicolons, so you must provide 
one when using a macro
- trailing commas in enums have been removed
- tm_isdst being set to -1 after conversions, I'll probably want to 
incorporate this more tightly into the Utc classes
- std::make_pair is no longer used
- std::labs being used as suggested
- using includes like cctype instead of ctype.h, which pulls in 
standard library methods into std namespace
   std is now used to reference all of these calls

A couple things.

The std::copy bit did not jive well with gcc.  We may need to write a 
runtime test to choose the proper method of copying maps.  We may need 
to write a configure test that exposes this STL bug and uses one or the 
other depending on the results.

I noticed you replaced some sprintf calls with ostringstreams.  We 
actually used to do this, but performance testing revealed that the 
sprintf calls were considerably faster.  I don't remember the exact 
numbers, but I believe using the sprintf calls made message 
construction something on the order of 10% faster.  That's pretty 
significant.  Is there a particular reason you changed these?

--oren