Re: [Quickfix-developers] How to set custom/user-defined fields

[Oren M. <om...@ri...>]

Yeah, we'll bump up up the version number.  I'd rather just fix the 
problem than pollute the API with extra methods.  We only bump the .so 
versions when doing a release anyway and there will almost surely be 
another change that will affect the ABI between now and then anyhow.

BTW back to the original topic, for future reference here is the 
section in the documentation that covers user defined fields: 
http://www.quickfixengine.org/quickfix/doc/html/user_defined.html

On May 17, 2004, at 12:44 PM, Caleb Epstein wrote:

> On Mon, May 17, 2004 at 10:26:08AM -0500, Oren Miller wrote:
>
>> Nope, that should be passed as a reference.  I made the change and
>> did a performance test and it actually doesn't make any difference, at
>> least when using an optimizer.  My guess is the optimizer is smart
>> enough to know that if you are passing in a const object, it might as
>> well pass it in as a reference anyway.  With the optimizer turned off
>> it there would be a significant difference.  In any case I'll check in
>> the change.
>
> 	It depends where you do your testing I wager.  With gcc,
> 	std::string is reference counted, so leaving off the & should
> 	be more or less harmless.  On other platforms, though,
> 	std::string has copy semantics and this may help speed things
> 	up.
>
> 	Nto sure if you care about "ABI" compatibility, but this
> 	interface change will cause your new quickfix lib to be
> 	runtime-incompatible with older versions (since it will no
> 	longere provde the the setField method that takes a plain
> 	string).  You may want to provide *both* forms or bump at least
> 	the .so version number.
>
> 	Small change but potentially large impact.
>
> -- 
> Caleb Epstein |  bklyn . org  |       T-shirt:
>     cae at    | Brooklyn Dust |       	Life is *not* a Cabaret, and 
> stop
> bklyn dot org |   Bunny Mfg.  |       	calling me chum!
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by: SourceForge.net Broadband
> Sign-up now for SourceForge Broadband and get the fastest
> 6.0/768 connection for only $19.95/mo for the first 3 months!
> http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click
> _______________________________________________
> Quickfix-developers mailing list
> Qui...@li...
> https://lists.sourceforge.net/lists/listinfo/quickfix-developers
>