Re: [SPAM] [Quickfix-developers] Infinite resend loop

[Joerg T. <Joe...@ma...>]

Hi James,

> Message has CORRECT body length, check sum, and sequence number; but FAILS
> message validation, e.g. MSgType=&.

Yes. We should add test cases for different variants, too. E.g. 
duplicate message tags, etc. There are some tests in the "future" 
sections which probably could used.

> Quick fix should send session level reject with clear reason, and increment
> the incoming sequence number to expect on the next message.

And log to the event log. This is important, too.

> Does this look correct? If so we should create a test for this test case. We
> should also review the existing test cases to ensure that we have proper
> coverage for message rejection.

Yes.

> Also are we considering all FIX versions or just 4.2 forward?

If the spec not explicitely prohibits this, we should add it. It 
improves useability in error situations dramatically (avoiding loops).

James, you are the guy which always says "I am adding an acceptance test 
for it..." :-) This is a Good Thing - thank you very much! Do you add 
these cases directly to the CVS repository? I haven't checked it lately, 
though.

Cheers, Jörg

-- 
Joerg Thoennes
                                http://macd.com
Tel.: +49 (0)241 44597-24      Macdonald Associates GmbH
Fax : +49 (0)241 44597-10      Lothringer Str. 52, D-52070 Aachen