Re: [Quickfix-developers] QuickFIX 1.4.1

[Joerg T. <Joe...@ma...>]

Oren Miller wrote:
> QuickFIX 1.4.1 is now available here:
> http://quickfix.thoughtworks.com/download.html

Thanks Oren for building this release. Now I can compile without errors. And more important:
The runtime problems (SIGRTMIN and SIGABRT) with 1.3.2 have gone. Now my Java process starts
and I can continue to develop the prototype applications. Many thanks again!!


Below there are some minor issues for purists ;-)

$ make

../Utility.h:118: warning: `const char*FIX::EOL' defined but not used

	This is seen at several places. IMHO, the std::endl could be used if
	the flush done by this construct does not matter.
	(See stdc++ doc:

>> Some people also believe that sending endl down an output stream only writes a newline. This is incorrect; after a newline is written, the buffer is also flushed. Perhaps this is the effect you want when writing to a screen -- get the text out as soon as possible, etc -- but the buffering is largely wasted when doing this to a file:

>>   output << "a line of text" << endl;
>>   output << some_data_variable << endl;
>>   output << "another line of text" << endl;
	
	The std::endl should also send '\r\n' on Windows, but I am not sure.)

	

org_quickfix_MySQLLog.cpp:127:19: warning: no newline at end of file
org_quickfix_MySQLLogFactory.cpp:125:19: warning: no newline at end of file

	These probably slipped through to the release.


$ make install

rm -rf /opt2/QuickFIX/linux/1.4.0/include/quickfix
mkdir /opt2/QuickFIX/linux/1.4.0/include/quickfix
mkdir: cannot create directory `/opt2/QuickFIX/linux/1.4.1/include/quickfix': No such file or directory

To fix this I added in src/C++/Makefile.am the line 116 below:

     114 install-exec-local: *.h
     115     rm -rf $(includedir)/quickfix
     116     -mkdir $(includedir)
     117     mkdir $(includedir)/quickfix
     118     mkdir $(includedir)/quickfix/include
     119     cp *.h $(includedir)/quickfix/include

The include files then install into

	/opt2/QuickFIX/linux/1.4.0/include/quickfix/include

which looks at little bit strange (double include).

IMHO, the src/C++/Makefile.am should be changed in the following way

- Move all *.h files from
	
	libquickfix_la_SOURCES = ...

   to

	pkginclude_HEADERS = ...

- Drop the install-local / uninstall-local target altogether.

This install the include file into

	/opt2/QuickFIX/linux/1.4.0/include/quickfix

and they can be accessed using

	#include <quickfix/...>

which seems to more standard than using

	#include "quickfix/include/..."

as in the examples. Of course, after doing that, QuickFIX probably has to be installed to be used by the
examples (and the tests).

In addition, it would be nice to install the generated quickfix.jar into the lib directory.
Change src/java/Makefile.am:

- Add

javadir = $(libdir)
java_DATA = ../../lib/quickfix.jar

- Drop the install-local / uninstall-local targets.


Anyway, I just start to understand autotool so my suggestions are just starting points.

Oren, could you please comment on these issues?

Thanks, Jörg

-- 
Joerg Thoennes
                                http://macd.com
Tel.: +49 (0)241 44597-24      Macdonald Associates GmbH
Fax : +49 (0)241 44597-10      Lothringer Str. 52, D-52070 Aachen