Re: [Quickfix-developers] Test Case failed

[<OM...@th...>]

This in and of itself shouldn't be a problem.  Yes, this will cause
subsequent instances of a field to silently overwrite the previous one,
but at the end of setString is a call to validate().  This checks fields 9
(length) and 10 (checksum) against the calculated values.  If a field gets
overwritten, there is a small chance that the checksum could still pass
(only 256 possibilities for checksum), but the length will certainly be
different and cause the message to fail validation.

This doesn't mean that there might not be a bug, I just don't think that
method is the cause.

ttCert provides full logs for all of their tests.  If you provide this an
automated test can be written to verify the behavior.

--oren



|---------+----------------------------------------------->
|         |           "Stancescu Constantin"              |
|         |           <Con...@sw...>      |
|         |           Sent by:                            |
|         |           qui...@li...|
|         |           ceforge.net                         |
|         |                                               |
|         |                                               |
|         |           02/13/2003 05:21 AM                 |
|         |                                               |
|---------+----------------------------------------------->
  >----------------------------------------------------------------------------------------------|
  |                                                                                              |
  |       To:       <qui...@li...>                                  |
  |       cc:       "Stancescu Constantin" <Con...@sw...>, "Gucher Gerhard"      |
  |        <Ger...@sw...>                                                              |
  |       Subject:  [Quickfix-developers] Test Case failed                                       |
  >----------------------------------------------------------------------------------------------|




During an acceptance test with ttCert for Bloomberg
we failed a test case specified also in the
 FIX Session-level Test cases
 h....field(tag number) ....specified more than once.
where our QuickFix engine just accepted the message.

My further investigation ended in the following piece of code

FieldMap.h
  /// Set a field without type checking
  void setField( const FieldBase& field )
  {
    m_fields.erase( field.getField() );
    m_fields.insert( std::make_pair( field.getField(), field ) );
  }

called from Message::setString, which explains the behaviour.

The spec expects a Reject(session-level) for this case....

Is this a bug ?


Regards,

Constantin

This message is for the named person's use only. It may contain
confidential, proprietary or legally privileged information. No
confidentiality or privilege is waived or lost by any mistransmission.
If you receive this message in error, please notify the sender urgently
and then immediately delete the message and any copies of it from your
system. Please also immediately destroy any hardcopies of the message.
You must not, directly or indirectly, use, disclose, distribute, print,
or copy any part of this message if you are not the intended recipient.
The sender's company reserves the right to monitor all e-mail
communications through their networks. Any views expressed in this
message are those of the individual sender, except where the message
states otherwise and the sender is authorised to state them to be the
views of the sender's company.




-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Quickfix-developers mailing list
Qui...@li...
https://lists.sourceforge.net/lists/listinfo/quickfix-developers