Re: [Quickfix-developers] Java Application::fromApp provides Message with lost groups

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

Make sure that the QuickFIX configuration file
specifies correct path to a Data Dictionary XML for
your session. On Unix the path specification has to be
relative to the FIX process working directory, (unless
another of our patches has made it to the release that
you are using)
We have an QuickFIX Java application that successfully
receives group News messages running on Linux, as long
as the Data Dictionary is found.

Gene
--- gar...@su... wrote:

<HR>
Can you confirm that this issue was fixed? &nbsp;I
rebuilt everything from the tagged checkout for
solaris w/ STL and I am not seeing any groups come
across on a fromApp call. &nbsp;I looked at the
Conversions.h that got checked out and it didn't have
the changes specified below (it still had the toString
calls). &nbsp;So I made the changes described below
and rebuilt the JNI layer and I still am not seeing
the groups come across.Can you verify that
groups come across now in the java version? &nbsp;
&nbsp;Is there any sure way I can tell if I've got the
right
source?&nbsp;Thanks,&nbsp;Gary
Mui Prescient Markets, Inc 914-989-3118 (W) 445
Hamilton Avenue 914-422-3693 (F) White Plains, NY
10601 Please visit us at <A
HREF=http://www.cpmarket.com>http://www.cpmarket.com</A>
&nbsp; OM...@th... Sent by:
qui...@li... 11/19/2002 02:02 PM CST To: mus...@ya...,
qui...@li... 
cc: se...@mi... bcc: Subject:
Re: [Quickfix-developers] Java
Application::fromApp provides Message with lost
groups Good catch guys. &nbsp;That
is a good patch. &nbsp;Anyone using groups in java
should apply it, I'll also add it to the
repository. You are right in noting that
the design for groups is not perfect.
&nbsp;It wasn't until support for groups was added
that a DataDictionary all of the sudden was
required in order to parse a message, so there are
definately a few issues that have bled
over. I
think that having the default data dictionaries
embedded into the code for use by the message is
probably a good idea. &nbsp;I think it is a
better idea than just using the configuration file
because I see use for the message class as a
standalone class. When there are sessions
available, I think it would be good to
have setString pick out the SessionID, do a
lookupSession, and pull out the data dictionary for
that session if available. &nbsp;If the session does
not exist and no data dictionary is passed in, it
will use the default based on the beginstring.
&nbsp;If a data dictionary is passed in, it will be
used no matter what. &nbsp;This should avoid the
need for custom begin strings.
&nbsp;Thoughts? --oren |---------+-----------------------------------------------&gt; |
&nbsp; &nbsp; &nbsp; &nbsp; | &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; Gene Gorokhovsky &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;| |
&nbsp; &nbsp; &nbsp; &nbsp; | &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &lt;mus...@ya...&gt; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;| | &nbsp;
&nbsp; &nbsp; &nbsp; | &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; Sent by: &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp;| | &nbsp; &nbsp; &nbsp; &nbsp; |
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
qui...@li...ur| | &nbsp;
&nbsp; &nbsp; &nbsp; | &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; ceforge.net &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
| | &nbsp; &nbsp; &nbsp; &nbsp; | &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
| | &nbsp; &nbsp; &nbsp; &nbsp; | &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
| | &nbsp; &nbsp; &nbsp; &nbsp; | &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; 11/19/2002 11:10 AM &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; | |
&nbsp; &nbsp; &nbsp; &nbsp; | &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
| |---------+-----------------------------------------------&gt; 
&nbsp;&gt;----------------------------------------------------------------------------------------------| 
&nbsp;| &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;| &nbsp;|
&nbsp; &nbsp; &nbsp; To: &nbsp; &nbsp; &nbsp;
OM...@th...,
qui...@li... &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp;| &nbsp;| &nbsp; &nbsp;
&nbsp; cc: &nbsp; &nbsp; &nbsp; se...@mi...
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; | &nbsp;| &nbsp; &nbsp; &nbsp; Subject:
&nbsp;[Quickfix-developers] Java Application::fromApp
provides Message with lost &nbsp; | &nbsp;| &nbsp;
&nbsp; &nbsp; &nbsp;groups &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp;| 
&nbsp;&gt;----------------------------------------------------------------------------------------------| Sergey Gribov and myself
discovered the following problem (QuickFIX
1.3.2): When receiving a message with Group fields,
the message is corrupted -- &nbsp;group information
is lost, and message length is invalid, by the time
it reaches Java Application fromApp and fromAdmin
callbacks. We traced the problem to JNI
layer. Here is the patch for src/java/Conversions.h
(tested on Linux/gcc 3.2.1) 124c124 &lt; &nbsp;
pMessage-&gt;setString( message.toString()
); --- &gt; &nbsp; *pMessage =
message; 141c141 &lt; &nbsp;
pMessage-&gt;setString( message.toString()
); --- &gt; &nbsp; *pMessage =
message; ------------------------------------------ While
the above patch fixes the immediate problem
at hand, this does expose a design issue: setString
does not work correctly for messages with repeating
groups if DataDictionary is not supplied. The
resulting message has a corrupted structure (group
count field has correct count, the rest of group
field are present only once). Athough setString
returns false (constructor using it even throws), I
think that this method with DataDictinary not
supplied is dangerous and should be hidden from the
public interface altogether, or at the very least
it should throw an exception. The upshot is that the
message cannot be safely restored from a string
without somehow externally knowing the
DataDictionary needed for that, despite source
string containing the protocol version
(which cannot be extracted without constructing
Message...) I think that there could be a
collection &nbsp;of DataDictionaries available to
Message internally based on the protocol's
BeginString value. They could be loaded based on
entries in the Default Section of the CFG
file DataDictionary.FIX41=./FIX41.xml, or perhaps
their content should be even be hard-coded as the
strings in one of the header files, since providing
a data-dict XML different from the one used to
generate code may not be such a hot idea. That way
sessions will refer to the version of the protocol,
with XML spec being an optional override, and
Message class will pick up the correct spec
themselves using BeginString, instead of always
relying on the DataDictionary
parameter. Custom tags will requite a
custom XML spec associated with a custom FIX
beginstring, or recompilation of quickfix code,
which I do not see as much of &nbsp;a problem,
since this is already required for type-safe usage
of the custom tags. Changes are also required for
non-validating mode, since this mode is currently
broken for reception of messages with repeating
groups -- Java fromApp is silently never called,
and C++ fromApp gets a corrupted
message. Perhaps this mode should be an explicit
setting in the config file, with meaningful
exceptions thrown when a message with repeating
tags is received. Gene __________________________________________________ Do
you Yahoo!? Yahoo! Web Hosting - Let the expert
host your site <A
HREF=http://webhosting.yahoo.com>http://webhosting.yahoo.com</A> ------------------------------------------------------- This
sf.net email is sponsored by: To learn the basics of
securing your web site with SSL, click here to get
a FREE TRIAL of a Thawte Server Certificate: <A
HREF=http://www.gothawte.com/rd524.html>http://www.gothawte.com/rd524.html</A> _______________________________________________ Quickfix-developers
mailing
list Qui...@li... <A
HREF=https://lists.sourceforge.net/lists/listinfo/quickfix-developers>https://lists.sourceforge.net/lists/listinfo/quickfix-developers</A> ------------------------------------------------------- This
sf.net email is sponsored by: To learn the basics of
securing your web site with SSL, click here to get
a FREE TRIAL of a Thawte Server Certificate: <A
HREF=http://www.gothawte.com/rd524.html>http://www.gothawte.com/rd524.html</A> _______________________________________________ Quickfix-developers
mailing
list Qui...@li... <A
HREF=https://lists.sourceforge.net/lists/listinfo/quickfix-developers>https://lists.sourceforge.net/lists/listinfo/quickfix-developers</A>

-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Quickfix-developers mailing list
Qui...@li...
https://lists.sourceforge.net/lists/listinfo/quickfix-developers

__________________________________________________
Do you Yahoo!?
Yahoo! Mail Plus - Powerful. Affordable. Sign up now.
http://mailplus.yahoo.com