Re: [Quickfix-developers] QickFix 1.3.1 : thread_spawn

[Manuel H. <mhe...@ca...>]

Oren,
I don't know what is a patch for you, but I send the 2 modified files.

All,
You can find in attachment the files Utility.h and Utility.cpp to install
in the directory src/C++.
I checked the modifications and it works.

Manuel HENRIQUES

(See attached file: Utility.h)(See attached file: Utility.cpp)





OM...@th... on 11/20/2002 05:50:24 PM

To:   mhe...@ca...
cc:   qui...@li...

Subject:  Re: [Quickfix-developers] QickFix 1.3.1 : thread_spawn



Manuel.  The best thing to do is to create a patch and post it on the
developers mailing list.  That way anyone who would like to patch for
themselves can apply it immediately, and developers with commit access ca=
n
apply it to the repository.

--oren



|---------+----------------------------------------------->
|         |           "Manuel HENRIQUES"                  |
|         |           <mhe...@ca...>       |
|         |           Sent by:                            |
|         |           qui...@li...ur|
|         |           ceforge.net                         |
|         |                                               |
|         |                                               |
|         |           11/20/2002 08:38 AM                 |
|         |                                               |
|---------+----------------------------------------------->
  >
-------------------------------------------------------------------------=
---------------------|

  |
|
  |       To:       qui...@li...,
|
  |        qui...@li...
|
  |       cc:
|
  |       Subject:  [Quickfix-developers] QickFix 1.3.1 : thread_spawn
|
  >
-------------------------------------------------------------------------=
---------------------|






Hi all,

I am using QuickFix 1.3.1. (C++)
I found the following problem:

There are 2 methods allowing to spawn threads in the file Utility.h
    bool thread_spawn( void*( *func ) ( void* ), void* var, int& thread )
    bool thread_spawn( void*( *func ) ( void* ), void* var )

The second one is used in files Initiator.cpp and Acceptor.cpp (at line
Acceptor.cpp:185 and Initiator.cpp:198):
    int threadid =3D thread_spawn( &startThread, this );

So in this line, the variable 'threadid' receives a boolean and not a
thread
id.

What I suggest in file Utility.h at line 103 is :
replace
                 int thread_spawn( void*( *func ) ( void* ), void* var );
by
                 bool thread_spawn( void*( *func ) ( void* ), void* var )=
;


and replace in file Utility.cpp at line 251
      bool thread_spawn( void*( *func ) ( void* ), void* var )
      {
         int thread =3D 0;
         return thread_spawn( func, var, thread );
      }
by
      int thread_spawn( void*( *func ) ( void* ), void* var )
      {
         int thread =3D 0;
         thread_spawn( func, var, thread );
         return thread;
      }

I don't know who is involved in checking these modifications and putting
them in the official code.
Can somebody help me ?

Thank you.

Manuel HENRIQUES

"This message,  including any attachments may contain confidential and
privileged material;  it is intended only for the person to whom it is
addressed.  Its  contents  do not  constitute  a commitment  by Cr=E9dit
Agricole Indosuez Cheuvreux  except  where  provided  for in a written
agreement.  Cr=E9dit Agricole Indosuez Cheuvreux assumes no liability or
responsibility for the consequences arising out of a delay and/or loss
in  transit  of  this  message,  or for corruption  or other  error(s)
arising in its transmission and for any misuse or fraudulent use which
may  be made thereof.  If you are not the  intended recipient,  please
contact us  and abstain from  any disclosure, use or dissemination. To
the extent  that  this message  contains  research information  and/or
recommendations,  these  are  provided  on  the  same  basis as Cr=E9dit
Agricole Indosuez Cheuvreux's  published  research  and  the recipient
must  have  regard  to  all   disclosures  and  disclaimers  contained
therein."




-------------------------------------------------------
This sf.net email is sponsored by: To learn the basics of securing
your web site with SSL, click here to get a FREE TRIAL of a Thawte
Server Certificate: http://www.gothawte.com/rd524.html
_______________________________________________
Quickfix-developers mailing list
Qui...@li...
https://lists.sourceforge.net/lists/listinfo/quickfix-developers