Re: [Quickfix-developers] quickfix memory leak

[K. F. <kfr...@gm...>]

Hi Oren!

On Fri, Sep 12, 2014 at 12:49 AM,  <or...@qu...> wrote:
>
> So it turns out there was a leak here.  The returned copies were not
> being stored in that collection and were never disposed of.  I solved
> this right now by putting them in std::shared_ptr objects.
> ...
> I think it would be nice to be able to use some modern smart pointers.
> When the project was started back in 2001, there was really nothing
> standardized that was widely distributed other than the dependency
> monster boost.  Now that there is I think it would help us avoid these
> types of memory pitfalls.

I would personally advocate for the use of std::shared_ptr (and other
standard smart pointers, as appropriate), but, of course, this would
make QuickFIX (partially) dependent on c++11.

For me, that's fine (in fact preferable), but I understand that many
users may have older toolchains that don't support the standard
smart pointers (or other c++11 / c++14 features).  What's been the
QuickFIX philosophy about adopting new language features when
they're beneficial?


Thanks.


K. Frank


>> -------- Original Message --------
>> Subject: Re: [Quickfix-developers] quickfix memory leak
>>
>> I don't see where this code can leak except program termination due to
>> missing cleanup for SessionFactoryu::m_dictionaries container.
>> ...