[Quickfix-developers] Possible bug in quickfixj FieldMap.removeGroup(int)

[David B. <dbu...@gm...>]

Hi Folks,

wasn't sure what the 'official' channel was to submit a patch / find if this
was a real issue.

QuickFixJ 1.1.0, FieldMap.java line 641
FieldMap.removeGroup(int)
does:

getGroups(field).clear();

Then it removes the counter field itself from the message.

Problem is, the string calculation code just iterates over the groups key
set and adds the groups in the message for each counter.
Which in effect gives you a counter who's value = 0 (since the list of Group
objects is empty from the clear, but the Integer counter key remains)

simple fix is just replacing that line with:
groups.remove(new Integer(field));

Works for us, and I can submit a patch if there's a proper place to do it.
I suppose another question is, should the counter be removed (it appears
that was the intention by the original function, just doesn't work that way
when building the fix string)?

Was hoping to get it in the main line (assuming it's the right thing to do
that is) so we don't have to re-patch as future revs come out.

Thanks,
-David