Re: [Quickfix-developers] Already sent ResendRequest ... Not sending another.

[Scott H. <sco...@fo...>]

I'm pretty sure the state.setResendRange(0,0) is in the patch I attached 
previously.  I was working from a diff of revisions 1.84 to 1.86.  Oddly, 
I cannot access revision 1.87 of Session.cpp in CVS at the moment (nor in 
the web-based ViewCVS), so I did miss Oren's latest patch.

On Mon, 9 Jan 2006, Caleb Epstein wrote:

> On 1/9/06, Scott Harrington <sco...@fo...> wrote:
>>
>> Thanks for patching the Session.cpp code to fix my problem.  I just today
>> caught up to things and have ported your fix to my local copy of
>> quickfixj/src/quickfix/Session.java.  The patch is attached; could we ask
>> Steve to review it and check it in to quickfixj?
>
>
> This looks like half of the fix, but you're missing the logic to reset the
> SessionState's resendRange back to (0,0) in Session::verify.  Here's the
> relevant section of the patch, which includes another fix Oren recently made
> for handling Logon messages containing ResetSeqNumFlag=Y
>
> --- Session.cpp 2 Jan 2006 21:26:37 -0000       1.85
> +++ Session.cpp 9 Jan 2006 16:04:56 -0000       1.87
> @@ -235,7 +235,7 @@
>
>   MsgSeqNum msgSeqNum;
>   logon.getHeader().getField( msgSeqNum );
> -  if ( isTargetTooHigh( msgSeqNum ) )
> +  if ( isTargetTooHigh( msgSeqNum ) && !resetSeqNumFlag )
>   {
>     doTargetTooHigh( logon );
>   }
> @@ -964,6 +964,20 @@
>       doTargetTooLow( msg );
>       return false;
>     }
> +
> +    if ( (checkTooHigh || checkTooLow) && m_state.resendRequested() )
> +    {
> +      SessionState::ResendRange range = m_state.resendRange();
> +
> +      if ( msgSeqNum >= range.second )
> +      {
> +        m_state.onEvent ("ResendRequest for messages FROM: " +
> +                         IntConvertor::convert (range.first) + " TO: " +
> +                         IntConvertor::convert (range.second) +
> +                         " has been satisfied.");
> +        m_state.resendRange (0, 0);
> +      }
> +    }
>   }
>   catch ( std::exception& e )
>   {
>
>
> --
> Caleb Epstein
> caleb dot epstein at gmail dot com
>