queue-developers

[Queue-developers] Minor new CVS release

[Werner G. K. <wer...@ya...>]

This new CVS release addresses a number of minor compiliation,
installation, and documentation issues since 1.40.1 beta.

It doesn't address everything (we're slowing iterating towards
convergence. Wonder if this compiles yet on SuSE and what still needs to
be fixed there.)

It fixes: time.h/sys/time.h RedHat 7 problem (and maybe other systems
like Solaris) in patch from Alan Eldridge (and pointed out by others.)

- Fixes minor info-dir problem that prevented info documentation from
getting installed

- Gets NFS out of ./configure.in and ./configure. Other minor changes to
docs include correction of timesched/timestop in texinfo file in doc
directory. Also change to profile.in suggested by mrc.

Enjoy.

Re: [Queue-developers] Minor new CVS release

[Mike C. <da...@ix...>]

On Fri, May 11, 2001 at 09:03:48PM -0400, Werner G. Krebs wrote:
> This new CVS release addresses a number of minor compiliation,
> installation, and documentation issues since 1.40.1 beta.


From the cvs, a ./configure followed by make clean leaves behind a couple
of droppings:

nexus@thune[9:24pm]src/queue/queue-development(526) cvs up
? doc/QueueVN.texi
M doc/queue.man


The texi file should be deleted.

Diff's on the man page are a little scary.

mrc

Index: doc/queue.man
===================================================================
RCS file: /cvsroot/queue/queue-development/doc/queue.man,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 queue.man
--- doc/queue.man       2000/05/17 22:39:37     1.1.1.1
+++ doc/queue.man       2001/05/12 04:25:24
@@ -1,4 +1,4 @@
-.TH queue 1 "01/1999" "GNU Queue Version 1.12.7" "GNU Queue"
+.TH queue 1 "07/2000" "GNU Queue Version 1.30.1 www.gnuqueue.org" "GNU Queue" 
 .SH NAME
 queue and qsh  - farm and batch-process jobs out on the local network
 .SH SYNOPSIS
@@ -370,7 +370,7 @@
 .SH COPYING
 Copyright
 .if t \(co
-1998, 1999 Werner G. Krebs
+1998-2000 W. G. Krebs \<wk...@gn...\>
 .PP
 Permission is granted to make and distribute verbatim copies of
 this manpage provided the copyright notice and this permission notice
@@ -378,6 +378,6 @@
 .SH BUGS
 Bug reports to \<bug...@gn...\>
 .SH AUTHORS
-Werner G. Krebs is the primary author of GNU Queue.
+W. G. Krebs \<wk...@gn...\> is the primary author of GNU Queue.
 .PP
 See Acknowledgements file for a complete list of contributors.

-- 
       Mike Castle       Life is like a clock:  You can work constantly
  da...@ix...  and be right all the time, or not work at all
www.netcom.com/~dalgoda/ and be right at least twice a day.  -- mrc
    We are all of us living in the shadow of Manhattan.  -- Watchmen

Re: [Queue-developers] Minor new CVS release

[Mike C. <da...@ix...>]

On Fri, May 11, 2001 at 09:03:48PM -0400, Werner G. Krebs wrote:
> This new CVS release addresses a number of minor compiliation,
> installation, and documentation issues since 1.40.1 beta.

A simple "queue -- hostname" results in the following email:

Date: Fri, 11 May 2001 22:43:50 -0700
To: ro...@mr...
From: The Queue Daemon <ro...@mr...>
Subject: queued error on mars.mrc-home.org: 'now/efm801954155': fchown(1,
501,
+100) failed: Bad file descriptor

'now/efm801954155': fchown(1, 501, 100) failed: Bad file descriptor

Which is caused by this bit of code:

  /* This creates a file owned by the user.  This means the user can
   * write into this file, so the user can start a long-sleeping batch
   * job and use this file for non-quota storage, but then the user
   * could do that with the user-owned input file too...  If this
   * fails, well, too bad; keep going.  -IAN!  */

  if( fchown(1, pw->pw_uid, pw->pw_gid) == -1 ){
    mperror3("'%s': fchown(1, %d, %d) failed",
             fname, pw->pw_uid, pw->pw_gid );
    /* no exit; just keep going */
  }


I think this is not valid.  Slightly above this code, we have:

  /* 
   * Close all (but debug_fd) file descriptors and open them as follows:
   *   0 - /dev/null
   *   1 - if (debug) then redirect output to debugfile, otherwise don't care.
   *   2 - if (debug) then redirect output to debugfile, otherwise don't care.
   */
              
  for (i = getdtablesize(); i--;) {if (i != debug_fd) close(i);}


So, I think it should be changed from fchown(1, to chown(fname, .

The following patch seems to work:


Index: queued.c
===================================================================
RCS file: /cvsroot/queue/queue-development/queued.c,v
retrieving revision 1.48
diff -u -r1.48 queued.c
--- queued.c	2001/05/11 22:49:59	1.48
+++ queued.c	2001/05/12 06:06:42
@@ -3739,8 +3739,8 @@
    * could do that with the user-owned input file too...  If this
    * fails, well, too bad; keep going.  -IAN!  */
 
-  if( fchown(1, pw->pw_uid, pw->pw_gid) == -1 ){
-    mperror3("'%s': fchown(1, %d, %d) failed",
+  if( chown(fname, pw->pw_uid, pw->pw_gid) == -1 ){
+    mperror3("chown(%s, %d, %d) failed",
 	     fname, pw->pw_uid, pw->pw_gid );
     /* no exit; just keep going */
   }

mrc
-- 
       Mike Castle       Life is like a clock:  You can work constantly
  da...@ix...  and be right all the time, or not work at all
www.netcom.com/~dalgoda/ and be right at least twice a day.  -- mrc
    We are all of us living in the shadow of Manhattan.  -- Watchmen

Re: [Queue-developers] Minor new CVS release

[Mike C. <da...@ix...>]

On Fri, May 11, 2001 at 09:03:48PM -0400, Werner G. Krebs wrote:
> It doesn't address everything (we're slowing iterating towards
> convergence. Wonder if this compiles yet on SuSE and what still needs to
> be fixed there.)

Btw, I just tested on a SuSE 7 and it compiled there (didn't run it, no
root access, but DID compile).

Same goes on a Debian 2.2 box.

They both DID have the following warning:

handle.c: In function `handle':
handle.c:704: warning: passing arg 1 of `gethostbyaddr' from incompatible pointer type

Both running libc 2.1.3.

On my homegrown box (literally no distribution), I don't see the warning
(libc 2.2.2).

mrc
-- 
       Mike Castle       Life is like a clock:  You can work constantly
  da...@ix...  and be right all the time, or not work at all
www.netcom.com/~dalgoda/ and be right at least twice a day.  -- mrc
    We are all of us living in the shadow of Manhattan.  -- Watchmen