Re: [Queue-developers] Queue 1.40.1 beta released

[Mike C. <da...@ix...>]

On Wed, May 09, 2001 at 11:02:06PM -0700, Mike Castle wrote:
> queued will not work without the -D option.
> 
> It will run, but no submissions can be made:

Ok.  Reading the stuff on sourceforge, I found someone else making this
same complaint, with more analysis.

The following change makes it possible to run queued without the -D option:

Index: queued.c
===================================================================
RCS file: /cvsroot/queue/queue-development/queued.c,v
retrieving revision 1.47
diff -u -r1.47 queued.c
--- queued.c    2001/05/09 22:35:51     1.47
+++ queued.c    2001/05/10 07:25:35
@@ -954,7 +954,7 @@
 
   systemflag = 0;              /* Clear HP-UX "system" call flag */
 
-#if 1
+#if 0
   /*
    * Go to sleep for a while before flooding the system with
    * jobs, in case it crashes again right away, or the


However, now I'm getting all sorts of annoying emails to root:

Date: Thu, 10 May 2001 00:24:09 -0700
To: ro...@mr...
From: The Queue Daemon <ro...@mr...>
Subject: queued error on thune.mrc-home.org: 'now/efm799285650': fchown(1,
501, 
+100) failed: Bad file descriptor
   
'now/efm799285650': fchown(1, 501, 100) failed: Bad file descriptor


The follow block of code seems abandoned, even as far back as 1.12.8:

from queued.c:

        
  if( fchown(1, pw->pw_uid, pw->pw_gid) == -1 ){
    mperror3("'%s': fchown(1, %d, %d) failed",
             fname, pw->pw_uid, pw->pw_gid );
    /* no exit; just keep going */
  }


Bracketing it with #if 0 / #endif seems to have no immediate ill effects.

mrc
-- 
       Mike Castle       Life is like a clock:  You can work constantly
  da...@ix...  and be right all the time, or not work at all
www.netcom.com/~dalgoda/ and be right at least twice a day.  -- mrc
    We are all of us living in the shadow of Manhattan.  -- Watchmen