[Queue-developers] time.h

[Mike C. <da...@ix...>]

Ok... looking through the list archive, this has been a sticking point for
people for a while.

Looking at define.h, we have several issues.

First, the following:

#ifdef HAVE_SYS_TIME_H
#include <sys/time.h>
#endif


exists at line 1, and line 115.  Not sure it's needed in both.


Second, we have the following:

#ifdef TM_WITH_SYS_TIME
#ifdef HAVE_TIME_H
#include <time.h>
#endif
#endif



Ok.  *either* tm is in sys/time.h or it's not.  If it's in sys/time.h, then
we've already included it above, so we don't need #ifdef at all.  If it's
NOT in sys/time.h, then we should be including time.h.

In short, I propose the following patch:

Index: define.h
===================================================================
RCS file: /cvsroot/queue/queue-development/define.h,v
retrieving revision 1.3
diff -u -r1.3 define.h
--- define.h    2001/04/11 15:29:29     1.3
+++ define.h    2001/04/25 04:36:25
@@ -134,7 +134,7 @@
 #include <syslog.h>
 #endif
 #include <termios.h>
-#ifdef TM_WITH_SYS_TIME
+#ifndef TM_WITH_SYS_TIME
 #ifdef HAVE_TIME_H
 #include <time.h>
 #endif


Then it at least compiles.

mrc
-- 
       Mike Castle       Life is like a clock:  You can work constantly
  da...@ix...  and be right all the time, or not work at all
www.netcom.com/~dalgoda/ and be right at least twice a day.  -- mrc
    We are all of us living in the shadow of Manhattan.  -- Watchmen