[Queue-developers] new intermediate development Queue version
Brought to you by:
wkrebs
From: QingLong <Qin...@bo...> - 2001-02-20 17:27:48
|
Hello! I've commited a few changes (3 bugfixes and 1 improvement/bugfix) to queue-development at sourceforge. ChangeLog notes follow: Made queued (handle.c) correctly assemble full path if the command is specified as relative path (./xxx or ../xxx). Also fixed a bug I have recently introduced in this same piece of code. Added a few trace messages (activated by --debug or --verbose). Fix: Made queue (queue.c) request loadaverage from remote host before trying to submit a job to it, if the host was explicitly specified on command line (-h or -H). This is necessary, as that host can turn out not to be running the given queue, if this is the case the submitted job will hang or sleep forever. Fix: (startjob() queued.c): a file for stdout redirection has been opened twice (thus, creating two fd's), once via creat(), and another time via open(). Although I fail to understand why it is so necessary to do the job twice, I added close() after creat() to make it work in accordance with comments (open fd 1 for /*stdout*/, and dup() it to fd 2 (rather than 3) for /*stderr*/). Changed QueueD behaviour in case of receiving a job on inactive queue. Made it just abort conection silently (queued.c check_query()). The queue protocol should have some way to return some error status indicator (and a descriptive error message) to client and to abort connection gracefully if client tries to do something unreasobnable or prohibited. Please give it a try. Thank you. QingLong. |