From: Martin M. <mar...@gm...> - 2020-12-05 14:16:35
|
Hi Felix, thanks for your response. Yes I'm looking at refactor+qt5-19 branch. Why do you wanna support multiple build systems? But it makes sense to have one place where all source and header files are define if multiple build systems are needed. With plugins you mean different features of qucs? So they aren't anymore part of the core, but only plugins? For me the structure of qucs is not that clear, in the main folder there is a qucs which is the GUI it self? Qucsator is in it's own repository so that it can be included or not, to add different solvers? In the qucs folder I find some "tools" (qucs-attenuator, qucs-filter, qucs-powercombining) are they completely standalone so that they can be included or not? And then in the qucs/qucs folder, the main stuff for the GUI is stored. cheers, Martin Am Sa., 5. Dez. 2020 um 14:24 Uhr schrieb Felix Salfelder < fe...@sa...>: > On Sat, Dec 05, 2020 at 10:01:45AM +0100, Martin Marmsoler wrote: > > I looked at the qucs project structure and I've seen that in the folder > > qucs/qucs exists a dialogs folder, but the dialogs it self are directly > > stored in qucs/qucs. Is there a plan to move these files back to the > > dialogs folder or is the plan to make a more flat project structure? > > > > I'm trying to update the cmake files. Therefore I need this information. > > Dear Martin. > > Thanks for looking into the CMake files. You are probably looking at the > refactor+qt5-19 branch. > > The relevant move forward is merge request 1007 [1]. It aims at > splitting up Qucs into library and plugins, supporting arbitrary build > systems, while keeping the source tree clean. If you are curious, The > same has been done here [2] in a related project. I think that in Qucs, > both the autotools build and the cmake build could be part of the main > repo. We need $toplevel/qucs/autotools and $toplevel/qucs/cmake > directories for this, and some less sketchy convention/agreement for > what is supposed to be in the MakeLists. > > Dialogs were in qucs/qucs/dialogs, but, as different elements have > different Dialogs, it does not seem sensible to expose specialised > dialogs to the global namespace. It seems that the dialogs directory > will go away, leaving behind only a header (in include?), and all > dialogs will be implemented (independently) within plugins alongside the > Element they correspond to. You will find that this is already the case > for most of them. > > Let me know if you have any questions. > > regards > felix > > [1] https://github.com/Qucs/qucs/pull/1007 > [2] http://gnucap.org/dokuwiki/doku.php/gnucap:manual:autotools > |