From: stefan <st...@lk...> - 2004-09-08 18:23:14
|
On Wed, 8 Sep 2004, Markus Schaber wrote: > Hi, Giorgio, Hello! > Giorgio bitflesh Luparia <bit...@au...> wrote: > > > On Tuesday 07 September 2004 18:28, stefan wrote: > > > Erm. Yes, someone else already reported the problem. Here proposed > > > > > > solution: > > > > You can type "atan2(double(...), double(...))" instead of > > > > "atan2(..., ...)", then it should work. > > > > > > as Michael did. > > > > > > > I note that now you include the C libraries in a C++ style as I said. That > > means that you have to call every standard library function in its std:: > > namespace! I think calling std::atan2 should solve the problem better than > > that small hack :) > > This does not work, I'm afraid, I still get the error that it's > ambigous. > > But the above fix using double() works, as it seems. > > I could have looked into this myself, just did not have the time right > now. I also agree with Michael's proposal. We should just verify that arguments are correct. > Could someone with CVS write permissions apply the following patch? > > diff -u -r1.35 diagram.cpp > --- qucs/diagrams/diagram.cpp 4 Sep 2004 07:37:33 -0000 1.35 > +++ qucs/diagrams/diagram.cpp 8 Sep 2004 13:00:26 -0000 > @@ -233,7 +233,7 @@ > *(p++) = ytmp; > continue; > } > - alpha = atan2(dy, dx); // slope for interpolation > + alpha = std::atan2(double(dy), double(dx)); // slope for interpolation > while(dist > 0) { // stroke or space finished ? > if(p >= p_end) { // need to enlarge memory block ? > Size += 256; I hope Michael will do that soon... > Maybe it even makes sense to apply the other patch as well: > > diff -u -r1.2 autogen.sh > --- autogen.sh 13 Jan 2004 16:11:38 -0000 1.2 > +++ autogen.sh 8 Sep 2004 12:59:55 -0000 > @@ -26,13 +26,13 @@ > cd `dirname $0` > > echo -n "Creating aclocal.m4... " > -aclocal > +aclocal-1.7 > echo "done." > echo -n "Creating config.h.in... " > autoheader > echo "done." > echo -n "Creating Makefile.in(s)... " > -automake > +automake-1.7 > echo "done." > echo -n "Creating configure... " > autoconf > > But this depends on whether other distros also use this versioning > scheme for different automake/aclocal versions. Erm, no I'll not do that because this is about a users system. Also it would disable the possibility to have different versions of automake/autoconf on your system and switching by symbolic links. You could introduce these links on your system, too. Cheers, st...@lk... |