Menu ▾ ▴

#31 add pkg-config generation to qmake build

Unstable_(example)
open
Sergey A. Tachenov
None
5
2017-06-04
2017-06-04
zgyarmati
No

Currently the qmake build doesn't provide any mean to help to link to the library. Mostly it's not a problem when building natively on Unix systems (the user can just add -lquazip to the linker flags and it's also easy to hit the include path), but it can be an important aid when cross-compiling.
This patch adds pkg-config .pc file generation to the quazip/quazip.pro file.
The .pc file also takes care of adding -DQUAZIP_STATIC as CFLAGS when built statically.
Consequently in most of the cases if the user uses qmake it's enough to add:

CONFIG += link_pkgconfig
PKGCONFIG += quazip

to her .pro file.

Please let me know if you see any room for improvement. Once this one is sorted out, i'm also planning to add .pc file generation to the cmake build.

1 Attachments
0001-add-pkg-config-generation-to-qmake-build.patch

Discussion

  • Sergey A. Tachenov

    Sergey A. Tachenov - 2017-06-04

    I don't have any experience configuring pkg-config, so I'll just apply whatever you provide. Applied this patch in r288.

     

  • zgyarmati

    zgyarmati - 2017-06-04

    Hi,

    ok, thanks. I have a pending pull request for MXE at https://github.com/mxe/mxe/pull/1780
    it's possible there will be some review also from there, and i'm also going to test this further, so let's keep it open, and i'll send here newer versions if any, or state that from my side it's ready.