#52 unitofmeasureconversionmanager.hpp change

closed-rejected
None
5
2010-09-13
2010-09-12
manas
No

removed friend reference to the class from which it is derived ie

class UnitOfMeasureConversionManager
: public Singleton<UnitOfMeasureConversionManager> {
friend class Singleton<UnitOfMeasureConversionManager>;

to

class UnitOfMeasureConversionManager
: public Singleton<UnitOfMeasureConversionManager> {

Discussion

  • Luigi Ballabio

    Luigi Ballabio - 2010-09-13
    • assigned_to: nobody --> lballabio
    • status: open --> open-rejected
     
  • Luigi Ballabio

    Luigi Ballabio - 2010-09-13

    No, the friend declaration is correct. The error was having the UnitOfMeasureConversionManager constructor public; it should be private (to prevent client code to instantiate it; only the Singleton machinery should) at which point the base Singleton class must be a friend. Thanks for the heads-up anyway; the issue will be fixed in next release.

     
  • Luigi Ballabio

    Luigi Ballabio - 2010-09-13
    • status: open-rejected --> closed-rejected
     

Log in to post a comment.