Re: [QStat-devx] Change of PacketFunc definition?

[Steve J. <ste...@ya...>]

--- Ludwig Nussel <l-...@us...> wrote:
> Steven Hartland wrote:
> > To prevent issues like:
> > qstat.h:895: warning: initialization from incompatible pointer type
> > 
> > I propose we change the definition of PacketFunc from:
> > typedef void (*PacketFunc)( struct qserver *, char *rawpkt, int pktlen);
> > to:
> > typedef int (*PacketFunc)( struct qserver *, char *rawpkt, int pktlen);
> 
> What's the return value of deal_with_halflife_packet good for? It
> doesn't seem to be used.
> 
> cu
> Ludwig
> 

Looks like a good idea, Steven.

I just looked through the code, and I did some wierd stuff for HL
when implementing the packet combiner.  HL is the only one that
returns int.  (see combine_packets())

So what are you going to return for the rest of the PacketFuncs?
I guess you could just ignore the return for all cases except HL.

Steve