#1 Version 2.2 failed to build with libgsl > 2

[Anonymous]

Hello,

I have tried to build the 2.2 version in Ubuntu (17.10) (libgsl-dev version: 2.4+dfsg-6), but it has failed with the following error:

In file included from src/data-processing-commands.cc:45:0:
src/bsplines.hh:43:3: error: ‘gsl_bspline_deriv_workspace’ does not name a type; did you mean ‘gsl_bspline_workspace’?
   gsl_bspline_deriv_workspace * derivWS;
   ^
   gsl_bspline_workspace
src/data-processing-commands.cc: In function ‘void __bl::baselineCommand(CurveEventLoop&, const QString&)’:
src/data-processing-commands.cc:592:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
         }
         ^
src/data-processing-commands.cc:594:7: note: here
       case CycleSplineType:
       ^
src/data-processing-commands.cc:601:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
         isLeft = true;
         ^
src/data-processing-commands.cc:602:7: note: here
       case Add10Right: {
       ^
Makefile:1985: recipe for target 'build/data-processing-commands.o' failed
make: *** [build/data-processing-commands.o] Error 1

This can be fixed by changing the #43 line in bsplines.hh by the following one (and including the gsl_version header):

#include <gsl/gsl_version.h>

#if GSL_MAJOR_VERSION < 2
 gsl_bspline_deriv_workspace * derivWS;
 #endif

[Vincent Fourmond]

Thanks for spotting this issue. Indeed, that is the only thing that need to be modified. I'm releasing an updated tarball as soon as the overnight build is over.

Kind regards,

Vincent

[Vincent Fourmond]

I've just released the source code of version 2.2.0, which fixes this problem.