qmmp / Tickets / #963 Quit including moc

#963 Quit including moc_hotkeymanager.cpp

Status: Fixed

Owner: trialuser02

Labels: None

Priority: Medium

OpSys:

Component:

Type: Defect

Updated: 2018-06-27

Created: 2018-06-13

Creator: Xiloynaha

Private: No

The attached patch helps with reproducible builds by suppressing two unneeded includes. Please see the original bug report at https://bugs.debian.org/891215
Matteo

1 Attachments

0001-Quit-including-moc_hotkeymanager.cpp.patch

Discussion

trialuser02 - 2018-06-17

status: New --> Fixed

assigned_to: trialuser02

Type: Enhancement --> Defect
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

trialuser02 - 2018-06-17

Fixed in svn. Thank you.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

trialuser02 - 2018-06-27

This fix is not correct because it breaks hotkey plugin::

OutputALSA: setupMixer() success QmmpUiPluginCache: error: Cannot load library /home/user/qmmp-1.2/lib/qmmp/General/libhotkey.so: (/home/user/qmmp-1.2/lib/qmmp/General/libhotkey.so: undefined symbol: _ZTV13HotkeyManager) QmmpUiPluginCache: unknown plugin type: /home/user/qmmp-1.2/lib/qmmp/General/libhotkey.so QmmpUiPluginCache: loaded plugin libcopypaste.so

So, I think this patch is not needed any more. cmake 3.11 builds qmmp-1.2.2 and does not require any patches.

Last edit: trialuser02 2018-06-27
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Quit including moc_hotkeymanager.cpp

Qt-based Multimedia Player

Searches

Help

#963 Quit including moc_hotkeymanager.cpp

Discussion