Menu

#1084 LADSPA plugin settings are not properly loaded

Fixed
None
High
Defect
2021-07-01
2021-07-01
No

qmmp 1.5.0 introduced a regression where LADSPA plugin settings are not loaded properly after restarting qmmp. This regression was not present in the 1.4.6.

Original report https://bugs.archlinux.org/task/71076

Patch to address the issue:

diff --git a/src/plugins/Effect/ladspa/ladspahost.cpp b/src/plugins/Effect/ladspa/ladspahost.cpp
index 65a1ccd..6a8cf30 100644
--- a/src/plugins/Effect/ladspa/ladspahost.cpp
+++ b/src/plugins/Effect/ladspa/ladspahost.cpp
@@ -53,7 +53,7 @@ LADSPAHost::LADSPAHost(QObject *parent) : QObject(parent)
         settings.beginGroup(section);

         int id = settings.value("id").toInt();
-        auto it = std::find_if(m_plugins.cbegin(), m_plugins.cend(), [id](LADSPAPlugin *p){ return p->unique_id = id; });
+        auto it = std::find_if(m_plugins.cbegin(), m_plugins.cend(), [id](LADSPAPlugin *p){ return p->unique_id == id; });
         if(it == m_plugins.cend())
             continue;

Discussion

  • Linearithmik

    Linearithmik - 2021-07-01

    *Type: Defect

     
  • trialuser02

    trialuser02 - 2021-07-01
    • Owner: Anonymous --> trialuser02
    • Status: New --> Accepted
    • Type: Review --> Defect
     
  • trialuser02

    trialuser02 - 2021-07-01
    • Status: Accepted --> Fixed
     
  • trialuser02

    trialuser02 - 2021-07-01

    Fixed in SVN. Thank you!

     

Log in to post a comment.

MongoDB Logo MongoDB