#14 Failed fetches will never try again

[Jon Schewe (BBN)]

I recently noticed that when a fetch fails it seems to keep failing. I looked at the retry logic in imagemanager.cpp and I'm pretty sure that in the following code snippet you want less than rather than greater than.

imagemanager.cpp:109
else if ( failedFetches.contains(url) && failedFetches[url].secsTo(QDateTime::currentDateTime()) > FAILED_TIMEOUT_SECONDS )
{
//prevents spamming public servers when requests fail to return an image or server returns error code (busy/ivalid useragent etc)
qDebug() << "Ignored: " << url << " - last request failed less than 30 seconds ago";
}

[Brad Grimmett]

ouch. yep your right, should be less than.
Fixing up now. Cheers

[Brad Grimmett]

Fixed in revision 54