Possible bug in SPP

[Roberto A. <ra...@kd...>]

Hello,

I wrote a plugin that reimplements the functionality of chkuser2 using SPP=
=20
(http://www.interazioni.it/opensource/chkuser/). If anyone wants a beta=20
version let me know :-)

But, I have run into something that looks like a SPP bug.

In qmail-smtpd.c, the patch puts this in smtp_rcpt:

if (!relayclient) allowed =3D addrallowed();

And later

  if (!(spp_val =3D spp_rcpt(allowed) return;

The problem is when you try to implement a rcpt plugin that checks for inva=
lid=20
local addresses.

When you are authenticated, or you have relay, you have relayclient enabled=
,=20
so allowed is never set, and remains (at least here ;-) set to 0.

So, all addreses seem to be non-rcpthosts, and no validation occurs.

I changed it to=20

allowed =3D addrallowed();

and have not had any adverse effects, authentication and relaying still see=
m=20
to work pretty much in the usual manner.

I am using a quite heavily patched qmail, but the auth patch is from=20
http://www.fehcom.de/qmail.html

=2D-=20
=A0("\''/").__..-''"`-. . =A0 =A0 =A0 =A0 Roberto Alsina
=A0`9_ 9 =A0) =A0 `-. ( =A0 =A0).`-._.`) =A0r...@kd...
=A0(_Y_.)' ._ =A0 ) `._`. =A0" -.-' =A0 KDE Developer (MFCH)
=A0 _..`-'_..-_/ /-'_.'
(l)-'' ((i).' ((!.' =A0 Buenos Aires - Argentina
Imminentizing the eschaton since 1971.